bugfix: ignore out-of-workspace didOpen in fallback (main-v2) - #8738
bugfix: ignore out-of-workspace didOpen in fallback (main-v2)#8738russwyte wants to merge 3 commits into
Conversation
Port of scalameta#8737 for the 2.0 line. Short-circuit fallback didOpen outside workspace folders, clear diagnostics, and skip Scala CLI auto-start / presentation-compiler load. Independent of scalaCliEnabled (still opt-in on main-v2). Fixes scalameta#8736 for milestone builds.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Backport of #8737 ( |
|
I will be backporting the changes this week in bulk before releasing a new milestone |
|
Ach, it's a new one, I will take a look then |
Keep API-only docs, demote ignore logs to debug, and expand unit/LSP edge cases (including lexical symlink membership) for reviewability.
2 participants
Summary
main-v2for 2.0 milestones.textDocument/didOpen, clears diagnostics, and skips Scala CLI auto-start / presentation-compiler load.ScalaCliAutoStartand is independent ofUserConfiguration.scalaCliEnabled(still opt-in on main-v2). The LSP suite enablesscalaCliEnabledso skip assertions are meaningful.Motivation
Same as #8737: editors can
didOpenScala files outside the workspace folders; Metals previously spawned Scala CLI BSP per orphan and flooded Problems.Test plan
unit/testOnly tests.ScalaCliAutoStartSuite(same policy edges as main, including lexical symlink membership)unit/testOnly tests.OutOfWorkspaceScalaCliLspSuite(outside/sibling/script/non-Scala/repeated outsiders; empty-folder policy against live folder list)SingleFileSuiteis already ignored). Policy coverage remains in the unit suite.