Add self healing to ValidateExistingBlob and validateManifest - #772
Draft
SuperSandro2000 wants to merge 1 commit into
Draft
Add self healing to ValidateExistingBlob and validateManifest#772SuperSandro2000 wants to merge 1 commit into
SuperSandro2000 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds self-healing during validation for replica manifests and blobs missing from storage.
Changes:
- Re-replicates missing manifests from upstream.
- Attempts recovery of missing blobs.
- Supplies tag policies and audit context for manifest replication.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/tasks/manifests.go |
Provides replication context during validation. |
internal/processor/manifests.go |
Adds missing-manifest recovery. |
internal/processor/blobs.go |
Adds missing-blob recovery logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+54
to
+58
| blob, err = p.FindBlobOrInsertUnbackedBlob(ctx, layerInfo, account.Name) | ||
| if err != nil { | ||
| return fmt.Errorf("blob could not be found while validating and replication failed: %w", err) | ||
| } | ||
| readCloser, _, err = p.sd.ReadBlobForValidation(ctx, account, blob.StorageID) |
Comment on lines
+182
to
+184
| // If we cannot find the manifest and the account is a replication from somewhere else try to get it from there | ||
| if errors.Is(err, keppel.NotFoundInStorageError{}) && (account.ExternalPeerURL != "" || account.UpstreamPeerHostName != "") { | ||
| manifest, manifestBytes, err = p.ReplicateManifest(ctx, account, repo, models.ManifestReference{Digest: manifest.Digest}, tagPolicies, actx) |
SuperSandro2000
force-pushed
the
self-heal-replicate
branch
from
August 10, 2026 20:56
1bb8c0b to
aeafae7
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.