drivers/multi: fix error propagation - #771
Merged
Merged
Conversation
SuperSandro2000
previously approved these changes
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cleanup-phase error propagation in the multi-storage driver.
Changes:
- Separates old-driver deletion errors from read errors.
- Corrects blob cleanup handling; manifest handling remains incomplete.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Because the variable `err` was used for both New.ReadFooForValidation and then Old.DeleteFoo, we always returned the error from the deletion, even if it was a NotFound error that should have been ignored.
majewsky
force-pushed
the
multi-fix-error-propagation
branch
from
August 10, 2026 12:36
231c33e to
5374e0a
Compare
SuperSandro2000
approved these changes
Aug 10, 2026
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the variable
errwas used for both New.ReadFooForValidation and then Old.DeleteFoo, we always returned the error from the deletion, even if it was a NotFound error that should have been ignored.