Skip to content

Ensure iiif manifests have id attributes by forcing UTF8 encoding of request.base_url #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjcolvar wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Ensure iiif manifests have id attributes by forcing UTF8 encoding of request.base_url #7542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/concerns/hyrax/works_controller_behavior.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ def iiif_manifest_builder

def iiif_manifest_presenter
IiifManifestPresenter.new(search_result_document(id: params[:id])).tap do |p|
p.hostname = request.base_url
# Have to force the encoding of base_url to UTF8 because Loofah will strip out ASCII-8BIT strings in Hyrax::ManifestBuilderService#deep_sanitize
p.hostname = request.base_url.force_encoding('UTF-8')
p.ability = current_ability
end
end
Expand Down
1 change: 1 addition & 0 deletions spec/features/iiif_manifest_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
visit "/concern/generic_works/#{work.id}/manifest"
manifest_json = JSON.parse(page.body)

expect(manifest_json['@id']).to match "http://.*/concern/monographs/#{work.id}/manifest"
expect(manifest_json['label']).to eq 'Comet in Moominland'
expect(manifest_json['description']).to eq 'a novel about moomins'

Expand Down
Loading