Skip to content

Fix Args Spec of Anomaly Constructors #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderkiel merged 1 commit into from
Sep 4, 2026
+26 −9
Merged

Fix Args Spec of Anomaly Constructors #4187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions modules/anomaly/src/blaze/anomaly_spec.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,40 +33,45 @@
:args (s/cat :x any?)
:ret boolean?)

(def ^:private constructor-args
"The message is only optional together with the key-value pairs, because the
constructors bind their first argument to the message positionally."
(s/? (s/cat :msg (s/nilable string?) :kvs (s/* (s/cat :k keyword? :v any?)))))

(s/fdef ba/unavailable
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/interrupted
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/incorrect
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/forbidden
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/unsupported
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/not-found
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/conflict
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/fault
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/busy
:args (s/cat :msg (s/? (s/nilable string?)) :kvs (s/* (s/cat :k keyword? :v any?)))
:args constructor-args
:ret ::anom/anomaly)

(s/fdef ba/anomaly
Expand Down
12 changes: 12 additions & 0 deletions modules/anomaly/test/blaze/anomaly_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,18 @@
::anom/message := "msg-183005"
::foo := ::bar)))

(def ^:private constructors
[`ba/unavailable `ba/interrupted `ba/incorrect `ba/forbidden `ba/unsupported
`ba/not-found `ba/conflict `ba/fault `ba/busy])

(deftest constructor-check-test
(testing "no argument list the args spec allows produces an invalid anomaly"
(doseq [sym constructors]
(testing (name sym)
(given (first (st/check sym {:clojure.spec.test.check/opts {:num-tests 100}}))
:sym := sym
:failure := nil)))))

(deftest anomaly-test
(testing "CompletionException"
(given (ba/anomaly (CompletionException. (Exception. "msg-184245")))
Expand Down
Loading