chore(testing): drop debian-11 testing container - #143
Closed
twangboy wants to merge 3 commits into
Closed
Conversation
Debian 11 (bullseye) reached end of LTS support on 2026-08-31, and is no longer covered by Salt's own supported-OS policy (Debian oldoldstable is only supported "if it is not EOL"). Remove the testing:debian-11 image now that Debian 11 test coverage is being dropped from salt and salt-bootstrap. Do NOT merge this until the following are merged first, or salt's and salt-bootstrap's CI will break trying to pull a container that no longer exists: - saltstack/salt-bootstrap#2131 - saltstack/salt#70238 - saltstack/salt-install-guide#91 Debian 12 and 13 remain covered, so Debian testing coverage is unaffected overall.
Docker was restricted to osrelease == '11' only (commit 310cd25, "Remove docker from amazon 2 and debian 12") with no recorded reason, and pkgs/docker.sls hardcoded the docker-ce pkgver to the bullseye (11) package suffix regardless of release. Debian 11 is being dropped as a testing container (EOL), which would otherwise leave Debian testing with zero docker coverage on any release. Confirmed live that Docker's official apt repo publishes matching docker-ce/docker-ce-cli builds, including the currently pinned 28.4.0-1, for bookworm (12) and trixie (13) just as it does for bullseye (11). Make the pkgver codename-aware and drop the osrelease == '11' guard so docker installs on all Debian releases again. The existing vault exclusion is trimmed to drop the now-dead '11' entry; trixie (13) is still excluded since HashiCorp doesn't publish a Release file for it.
The osrelease != '13' exclusion (commit 2dd25b0, Oct 2025) was added because HashiCorp's apt repo didn't yet publish a Release file for trixie at the time. Confirmed live that this is no longer the case: https://apt.releases.hashicorp.com/dists/trixie/Release now returns 200 with a real vault package in the Packages index, same as bookworm. Drop the exclusion; the arm64 exclusion is unrelated and untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debian 11 (bullseye) reached end of LTS support on 2026-08-31 and no longer
falls under Salt's own supported-OS policy
(Debian oldoldstable is only supported "if it is not EOL"). This removes the
testing:debian-11image. Debian 12 and 13 remain covered, so overall Debiantest coverage is unaffected.
custom/testing/debian-11.Dockerfiledebian-11fromcontainers.yml'sSalt Testing.versionsREADME.md/custom/testing/README.mdaccordinglyBonus fix: restore docker coverage on Debian 12/13
Docker was only ever installed on
osrelease == '11'in the golden-state-tree(commit
310cd259, no recorded reason), withpkgs/docker.slshardcoding thedocker-cepackage version suffix to bullseye regardless of release. Droppingdebian-11 outright would have left Debian testing with zero docker
coverage on any release.
Confirmed live that Docker's official apt repo publishes matching
docker-ce/docker-ce-clibuilds (including the currently pinned28.4.0-1)for
bookworm(12) andtrixie(13), same asbullseye(11). Made thepkgver codename-aware and dropped the
osrelease == '11'guard so dockerinstalls on all Debian releases again.
Bonus fix: re-enable vault on Debian 13 (trixie)
The
osrelease != '13'exclusion (commit2dd25b0, Oct 2025) was addedbecause HashiCorp's apt repo didn't yet publish a Release file for trixie at
the time. Confirmed live that this is no longer the case -
https://apt.releases.hashicorp.com/dists/trixie/Releasenow returns 200with a real
vaultpackage in the Packages index, same as bookworm. Droppedthe exclusion (the unrelated arm64 exclusion is untouched).
This is opened as a draft and must stay that way until all three of the
following are merged, since they're what actually stop
saltandsalt-bootstrapCI from trying to pull atesting:debian-11image that nolonger exists:
Once those land, mark this ready for review and merge.