Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Present the MIT-licensed project as a Bitcoin-like Python cryptocurrency implementation with a usable first-run experience. Add Linux/macOS and Windows setup, a documentation index, troubleshooting and API/component guides, an offline example, changelog, issue/PR templates and documentation link checks. Rework CI around core dependencies and five platform/Python jobs; retain Linux CLI packaging as a separate manual workflow rather than coupling it to optional GPU/GUI installs. No automatic release, Ethereum compatibility, production audit or live-service claims.
Evidence
After: runnable temporary-wallet/signature/block-header example, platform setup and focused core CI. Encryption and legacy unlock fail explicitly; flagged wallet saves are blocked. Wallet saves use owner-only atomic replacement on POSIX; unsupported HD passphrase creation is rejected. RPC rejects partial/empty credentials and unauthenticated non-loopback binds, strictly decodes Basic headers and compares credentials in constant time. Exchange RPC/REST bind locally, require explicit credentials and omit password logging. RPC shutdown uses the matching serve_forever loop.
Merge Danger
Door: two-way
No consensus parameters or historical commits changed. Legacy wallet files are preserved. Intentional compatibility changes: encryption/unlock no longer pretend to work; new HD extra-passphrase creation is blocked; exchange credentials are mandatory and public RPC/REST bindings removed. Remote exchange access needs a restricted proxy/tunnel. CI now runs focused core checks; executable builds require manual dispatch, with mnemonic wordlist included in the daemon bundle.
Blast Radius: developers/operators
Wallet keys remain plaintext and REST unauthenticated. Genesis mismatch substitution, incomplete testnet isolation, dependency locking and optional-component deployment remain documented limitations. The new coin guide is an engineering checklist, not a verified one-command network generator. Founder privacy and existing attribution are preserved.
GitHub About/topics remain unchanged: the connector exposes no metadata-write tool and the available CLI account lacked access. Suggested metadata was provided in the chat deliverable.