update x509-limbo pin for ML-DSA test coverage - #517
Open
cpu wants to merge 2 commits into
Open
Conversation
Add rustls-post-quantum as a dev-dependency and include its ML-DSA-44, ML-DSA-65 and ML-DSA-87 verification algorithms alongside ALL_VERIFICATION_ALGS in the x509-limbo harness.
Update the x509-limbo pin to pick up the new rfc9881:: testcases covering ML-DSA certificate verification. Four of the six new testcases pass, including rfc9881::ml-dsa-44-bad-signature, demonstrating that ML-DSA signatures are genuinely verified. The remaining two are pedantic-rfc5280 testcases expecting rejection of ML-DSA EE certs asserting keyAgreement/keyEncipherment key usage that we don't do presently. This might be worth revisiting more holistically in the future, especially for new algorithms like ML-DSA.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 97.64% 97.61% -0.03%
==========================================
Files 20 20
Lines 4070 4070
==========================================
- Hits 3974 3973 -1
- Misses 96 97 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ctz
approved these changes
Jul 27, 2026
djc
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the x509-limbo pin to pick up the new rfc9881:: testcases covering ML-DSA certificate verification (C2SP/x509-limbo#644). Four of the six new testcases pass, the remaining two are pedantic-rfc5280 testcases expecting rejection of ML-DSA EE certs asserting keyAgreement/keyEncipherment key usage. We don't enforce that presently. This might be worth revisiting more holistically in the future, especially for new algorithms like ML-DSA.