Skip to content

Audio Params ignored when input is a VPY #1271

Open

Description

@hasezoey

av1an 805dad6

I noticed that -a / --audio-params gets silently ignored when the input is a VPY, the documentation also does not note that.

For context:
I just tried to use a vpy as a input to cut some files, which works fine, on the video side.
After it finished i noticed that it did not have any audio, which i guess is expected as the audio is not cut, so i tried using -a with -ss and -to to manually cut it, but even then there was no audio.
I re-checked the documentation just to be sure, but nothing was noted there, so i had gone to the source, where i found:

// vapoursynth audio is currently unsupported
let audio_thread = (self.args.input.is_video()
&& (!self.args.resume || !get_done().audio_done.load(atomic::Ordering::SeqCst)))

Please:

  • properly support audio when the input is VPY (maybe warn if no custom options are specified)
  • properly document this limitation and maybe add a warning (or error) if the option is specified
  • properly support trimming / cutting

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions