Skip to content

grand-flip-out: update to 5af290e - #14603

Open
Tunatroll wants to merge 2 commits into
runelite:masterfrom
Tunatroll:gfo-s4-fill-feedback
Open

grand-flip-out: update to 5af290e#14603
Tunatroll wants to merge 2 commits into
runelite:masterfrom
Tunatroll:gfo-s4-fill-feedback

Conversation

@Tunatroll

Copy link
Copy Markdown
Contributor

Updates grand-flip-out to 49786a6.

User-reported UX fixes (plugin Discord #feedback):

  • The Advisor's "Fill offer" button now shows armed feedback on the button itself (relabels + disables until the next card render) instead of only a game-chat line; when the auto-fill setting is off the label is unchanged and the chat line names the setting.
  • The advisor card is pinned while the player enters the armed offer, so another slot's offer event can no longer swap the suggestion mid-entry. Reuses the existing held-for-sell mechanism, bounded by the existing 90s fill-arm TTL; a terminal buy upgrades to the existing unbounded hold; all release paths unchanged.
  • A tracker map crossed by the EDT and the client thread is now a ConcurrentHashMap.

No new APIs, no new automation — the fill remains arm-only (player opens the offer and confirms). Tests: 132/0 (cleanTest test), incl. a new suite pinning the hold lifecycle and button labels.

@runelite-github-app

runelite-github-app Bot commented Aug 2, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Aug 2, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Tunatroll Tunatroll changed the title grand-flip-out: update to 49786a6 grand-flip-out: update to 5af290e Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant