osrscn: 0.2.1 - #14520
Open
Aoldbald wants to merge 1 commit into
Open
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the upload half of what used to be one PR, split off so the last release carried no network change. It is the only thing in this version.
What it does. Players who want to help fix missing translations can let the plugin send the English it could not translate, instead of copying a file into a GitHub issue by hand, which turned out to be unrealistic for most of the people using it.
Off by default. Turning it on opens a dialog that spells out what gets sent, and it can be turned off again at any time.
What is sent: the untranslated game English the lookup tables missed, plus a random six character install id so repeat contributions from one person can be recognised. No chat, no account data. Player names are replaced with a placeholder before a line is ever recorded, and lines containing CJK are refused outright, since those are player authored.
Where it goes: a Cloudflare Worker I run, which forwards to the plugin's translation data repository. The worker holds the write token, so the client never has one. It validates the id format and caps size.
Pacing: incremental against a local watermark, at most 400 rows a batch, at most once every 30 minutes, on the injected scheduled executor. If the endpoint is not configured the whole feature sleeps.
Happy to extend the existing warning line to mention the upload, or to change anything about how it is presented.