Subclasses of string loses encoding - #178
Closed
iwiznia wants to merge 1 commit into
Closed
Conversation
Author
|
Anyone up for a pair programming session to try to solve this? @tenderlove? |
Author
|
It would be great to try to fix this before ruby 2.2.0 gets released... |
Member
|
Closing this test-only PR. ASCII-only binary strings load back as UTF-8 whether or not they are subclasses, and changing that would alter the loaded value of existing documents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When subclassing string, the deserialized object loses the encoding.
This is just the test, I really don't know where to fix this. Would be happy to do it if someone points me in the right direction...