Skip to content

Bandwidth-exceeded notice: say videos keep playing - #2398

Open
subodhr258 wants to merge 1 commit into
developfrom
fix/2397-bandwidth-notice-text
Open

subodhr258 wants to merge 1 commit into
developfrom
fix/2397-bandwidth-notice-text

Conversation

@subodhr258

Copy link
Copy Markdown
Collaborator

What and why

When a site goes over its bandwidth limit, the admin notice said "Videos might not be served from CDN on frontend." Central never stops CDN delivery at the bandwidth limit (confirmed with the Central team on 19 Nov), and godam.io/pricing/ says videos keep playing. This PR changes the notice to say what really happens. Only full storage stops anything (new transcodes), and that notice is unchanged.

Closes #2397.

Where to look

The whole PR is one string. The only place it could go wrong is the %s%% placeholder, which must stay intact for sprintf:

  1. Bandwidth-exceeded notice text (admin/class-rtgodam-transcoder-admin.php:598)
    __( 'Your bandwidth usage (%s%%) has exceeded your plan limit. Your videos keep playing; upgrade your plan to stay within your limit.', 'godam' ),
    Check: the wording is fine for product (the issue left the exact text to product's call).

languages/godam.pot: the matching msgid, same line reference. I checked it against a fresh wp i18n make-pot --slug=godam run on the changed file; the entry matches byte for byte.

UI evidence

Notice on wp-admin › Plugins, with the site's cached usage set to bandwidth 120% of the plan and storage under the limit.

Before (develop):

After (this branch):

How to test

  1. On a test site with an API key, set the cached usage so bandwidth is over the limit and storage is not, for example:
    wp eval '$d = get_option("rtgodam_user_data"); $d["bandwidth_used"] = 120; $d["total_bandwidth"] = 100; $d["storage_used"] = 1; $d["total_storage"] = 100; $d["timestamp"] = time(); update_option("rtgodam_user_data", $d);'
  2. Open any wp-admin page other than the Dashboard (the Dashboard widget shows its own alerts), e.g. Plugins.
  3. The red "GoDAM Bandwidth Exceeded" notice reads "Your bandwidth usage (120.0%) has exceeded your plan limit. Your videos keep playing; upgrade your plan to stay within your limit."
  4. Use "Refresh Status" or wait for the next check to restore the real usage.

Risk

risk: low because it changes one translatable string and its POT entry; no logic changes.

The notice warned that videos might not be served from the CDN once
bandwidth passes the plan limit, but Central never stops delivery at
that limit. Reword it to match Central and the pricing page, and
update the POT entry.

Fixes #2397
@subodhr258 subodhr258 added the risk: low QA automation only (Dependabot fixes, copy, CSS) label Nov 19, 2026
@github-actions

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
15 0 15

⚠️ Warnings (15)

📁 readme.txt (2 warnings)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM".
0 readme_parser_warnings_trimmed_section_description The "Description" section is too long and was truncated. A maximum of 2500 characters is supported.
📁 inc/classes/class-media-library-ajax.php (1 warning)
📍 Line 🔖 Check 💬 Message
1643 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "max_srcset_image_width".
📁 assets/build/pages/video-editor.min.js (1 warning)
📍 Line 🔖 Check 💬 Message
2 react_removed_api This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/19/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/19/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low QA automation only (Dependabot fixes, copy, CSS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant