Repository navigation
Add data-test-id to the LearnDash video picker - #2396
Merged
Merged
Conversation
kishan-gondaliya-7270
self-requested a review
November 19, 2026 10:28
kishan-gondaliya-7270
approved these changes
Nov 19, 2026
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM". |
0 |
readme_parser_warnings_trimmed_section_description | The "Description" section is too long and was truncated. A maximum of 2500 characters is supported. |
📁 inc/classes/class-media-library-ajax.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
1643 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound | Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "max_srcset_image_width". |
📁 assets/build/pages/video-editor.min.js (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
2 |
react_removed_api | This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
The LearnDash Video Progression surfaces from #2376 shipped with no data-test-id, so automated UI tests had nothing stable to target. Add hooks following the plugin's godam-<area>-<element> convention to the "Use GoDAM Video" switch, the video picker (container, hidden input, preview wrapper, preview player, title) and the Select/Replace and Remove buttons. The switch and preview player are rendered by LearnDash and in JS respectively, so their attributes are set in admin.js; the rest are in the picker markup. The additions are placed to keep the existing PHP assertions intact, with the __remove assertion updated and picker/JS assertions added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
KMchaudhary
force-pushed
the
fix/learndash-data-test-id
branch
from
November 19, 2026 10:56
141c031 to
8c606d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
data-test-idhooks to the LearnDash Video Progression picker UI from #2376, which shipped without any, so automated UI tests have stable targets. Attributes only — every element keeps its class/id, so nothing that already selected these nodes changes. Follows the plugin'sgodam-<area>-<element>convention.data-test-idgodam-learndash-use-godam-switchgodam-learndash-video-{picker,input,preview,title}<video>godam-learndash-video-preview-playergodam-learndash-video-{select,remove}The switch and preview player are rendered by LearnDash and in JS respectively, so their attributes are set in
admin.js; the rest are in the picker markup (class-learndash.php).Scope note
Trimmed to the LearnDash picker only. The transcode-failure test-ids this PR also carried were the same work as #2393, already merged into
develop, so that commit was dropped to avoid duplication.Tests
learndash/admin.test.js(14) andLearnDashIntegrationTest(51) pass, with new assertions for the switch, preview player and picker hooks; phpcs and ESLint clean.🤖 Generated with Claude Code