Repository navigation
Decode the LearnDash Video URL without reinterpreting it as HTML - #2391
Merged
Merged
Conversation
CodeQL flagged `textarea.innerHTML = value` in the Video URL decode helper as DOM text reinterpreted as HTML. Replace the textarea round-trip with a targeted decode of just the entities WordPress escaping produces, so the field value is never parsed as HTML. `&` is decoded last to avoid double-decoding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM". |
0 |
readme_parser_warnings_trimmed_section_description | The "Description" section is too long and was truncated. A maximum of 2500 characters is supported. |
📁 inc/classes/class-media-library-ajax.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
1643 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound | Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "max_srcset_image_width". |
📁 assets/build/pages/video-editor.min.js (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
2 |
react_removed_api | This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Member
|
Reviewed 1d035f3. The fix is fine and removes the CodeQL sink. No blockers. Checked
For context, the old Nit (optional)
Ready to approve from my side. |
rudrakshi-gupta
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Resolves the CodeQL finding on the v2.11.0 develop→main sync (#2389): "DOM text reinterpreted as HTML" in
assets/src/js/learndash/admin.js.The
decodehelper that reads the saved LearnDash Video URL used atextarea.innerHTML = valueround-trip to decode HTML entities. CodeQL flags assigning page-derived text toinnerHTMLas a potential XSS sink.The value is only ever checked against the GoDAM marker shortcode, so a full HTML parse is unnecessary. This replaces the round-trip with a plain string replacement of just the entities WordPress escaping produces (
<,>,",'/',',&), so the field value is never reinterpreted as HTML.&is decoded last so an already-escaped ampersand is not decoded twice. The now-unuseddocparameter is dropped.Where to look
assets/src/js/learndash/admin.js— thedecodehelper and its single caller.How to test
npx jest assets/src/js/learndash/admin.test.js— all 14 tests pass, including the case that saves the marker with"-escaped quotes and expects it cleared when the switch is turned off.Risk
risk: low— behaviour is unchanged for every value the field holds; only the decoding mechanism changed.🤖 Generated with Claude Code