Repository navigation
Date the Layer API deprecations to 2.9.0 - #2359
Merged
Merged
Conversation
GoDAM 2.8.0 shipped on 10 Nov without the Layer API, so the old layer hooks are deprecated in 2.9.0, the release that brings it (rtCamp/godam-plugin-wp#108). Following the two-minor-release rule, they are removed in 2.11.0. Updates HOOKS_DEPRECATED_SINCE and the @deprecated tag in PHP, DEPRECATED_SINCE / REMOVED_IN in JS, the layer-registry docblock, docs/layer-api.md, and the tests that assert the notice text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the Layer API deprecation-schedule update.
No open issues 🎉
What changed in this PR
Aligns Layer API deprecation dates with its planned GoDAM 2.9.0 release, since 2.8.0 shipped without the API. Legacy hooks remain scheduled for removal two minor releases later, in 2.11.0.
Changes:
- Updates PHP and JavaScript deprecation version constants.
- Aligns developer documentation and code comments with the revised schedule.
- Updates PHP and Jest notice assertions to match.
| File | Description |
|---|---|
tests/php/LayerTypeRegistryTest.php |
Expects the PHP hook notice to report 2.9.0. |
pages/video-editor/layers/layers.test.js |
Updates legacy creator and component notice assertions. |
pages/video-editor/index.test.js |
Updates the legacy editor-actions notice assertion. |
pages/video-editor/components/SidebarLayers.test.js |
Updates the legacy creator notice assertion. |
pages/video-editor/components/layers/Layer.test.js |
Updates the legacy component notice assertion. |
inc/classes/layers/class-layer-type-registry.php |
Revises the PHP deprecation constant and docblocks. |
docs/layer-api.md |
Documents the 2.9.0 requirement and 2.11.0 removal schedule. |
assets/src/js/godam-player/utils/layer-registry.test.js |
Updates the legacy runtime-registration notice assertion. |
assets/src/js/godam-player/utils/layer-registry.js |
Revises deprecation dates in the docblock only. |
assets/src/js/godam-layers/deprecated.js |
Updates shared JavaScript deprecation and removal constants. |
Review effort: Balanced
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM". |
📁 assets/build/pages/video-editor.min.js (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
2 |
react_removed_api | This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/11/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/11/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
subodhr258
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 2.9.0, the Layer API release (#2290). Follow-up to #2345.
In one line: The old layer hooks are now marked deprecated in 2.9.0 and removed in 2.11.0, because 2.8.0 shipped without the Layer API.
What changed
inc/classes/layers/class-layer-type-registry.phpHOOKS_DEPRECATED_SINCE2.9.0, the@deprecatedtag ongodam_player_render_layer, and "removed in 2.11.0" in the docblockassets/src/js/godam-layers/deprecated.jsDEPRECATED_SINCE2.9.0,REMOVED_IN2.11.0assets/src/js/godam-player/utils/layer-registry.jsdocs/layer-api.mdThe PHP notices (
apply_filters_deprecated(),_deprecated_hook()) and the JS console notice all read these constants, so no other code changes.Testing
2.8.0/2.10.0left in the Layer API code, docs or tests.Risk
risk: low: version strings in deprecation notices, docs and tests only.🤖 Generated with Claude Code