Skip to content

Date the Layer API deprecations to 2.9.0 - #2359

Merged
KMchaudhary merged 1 commit into
developfrom
fix/layer-api-deprecation-version
Nov 12, 2026
Merged

KMchaudhary merged 1 commit into
developfrom
fix/layer-api-deprecation-version

Conversation

@KMchaudhary

Copy link
Copy Markdown
Collaborator

Part of 2.9.0, the Layer API release (#2290). Follow-up to #2345.

In one line: The old layer hooks are now marked deprecated in 2.9.0 and removed in 2.11.0, because 2.8.0 shipped without the Layer API.

What changed

File Change
inc/classes/layers/class-layer-type-registry.php HOOKS_DEPRECATED_SINCE 2.9.0, the @deprecated tag on godam_player_render_layer, and "removed in 2.11.0" in the docblock
assets/src/js/godam-layers/deprecated.js DEPRECATED_SINCE 2.9.0, REMOVED_IN 2.11.0
assets/src/js/godam-player/utils/layer-registry.js Docblock
docs/layer-api.md "Requires GoDAM 2.9.0", hooks work until 2.11.0, "Deprecated since 2.9.0" table header
PHP and Jest tests The asserted notice text

The PHP notices (apply_filters_deprecated(), _deprecated_hook()) and the JS console notice all read these constants, so no other code changes.

Testing

  • PHPUnit: 1,465 tests pass.
  • Jest: 1,264 tests pass.
  • No 2.8.0 / 2.10.0 left in the Layer API code, docs or tests.

Risk

risk: low: version strings in deprecation notices, docs and tests only.

🤖 Generated with Claude Code

GoDAM 2.8.0 shipped on 10 Nov without the Layer API, so the old layer
hooks are deprecated in 2.9.0, the release that brings it
(rtCamp/godam-plugin-wp#108). Following the two-minor-release rule,
they are removed in 2.11.0.

Updates HOOKS_DEPRECATED_SINCE and the @deprecated tag in PHP,
DEPRECATED_SINCE / REMOVED_IN in JS, the layer-registry docblock,
docs/layer-api.md, and the tests that assert the notice text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KMchaudhary KMchaudhary added the risk: low QA automation only (Dependabot fixes, copy, CSS) label Nov 11, 2026
Copilot AI balanced review requested due to automatic review settings November 11, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the Layer API deprecation-schedule update.

No open issues 🎉

What changed in this PR

Aligns Layer API deprecation dates with its planned GoDAM 2.9.0 release, since 2.8.0 shipped without the API. Legacy hooks remain scheduled for removal two minor releases later, in 2.11.0.

Changes:

  • Updates PHP and JavaScript deprecation version constants.
  • Aligns developer documentation and code comments with the revised schedule.
  • Updates PHP and Jest notice assertions to match.
File Description
tests/​php/​LayerTypeRegistryTest.php Expects the PHP hook notice to report 2.9.0.
pages/​video-editor/​layers/​layers.test.js Updates legacy creator and component notice assertions.
pages/​video-editor/​index.test.js Updates the legacy editor-actions notice assertion.
pages/​video-editor/​components/​SidebarLayers.test.js Updates the legacy creator notice assertion.
pages/​video-editor/​components/​layers/​Layer.test.js Updates the legacy component notice assertion.
inc/​classes/​layers/​class-layer-type-registry.php Revises the PHP deprecation constant and docblocks.
docs/​layer-api.md Documents the 2.9.0 requirement and 2.11.0 removal schedule.
assets/​src/​js/​godam-player/​utils/​layer-registry.test.js Updates the legacy runtime-registration notice assertion.
assets/​src/​js/​godam-player/​utils/​layer-registry.js Revises deprecation dates in the docblock only.
assets/​src/​js/​godam-layers/​deprecated.js Updates shared JavaScript deprecation and removal constants.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
13 0 13

⚠️ Warnings (13)

📁 readme.txt (1 warning)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM".
📁 assets/build/pages/video-editor.min.js (1 warning)
📍 Line 🔖 Check 💬 Message
2 react_removed_api This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@KMchaudhary
KMchaudhary merged commit 6f4b475 into develop Nov 12, 2026
6 checks passed
@KMchaudhary
KMchaudhary deleted the fix/layer-api-deprecation-version branch November 12, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low QA automation only (Dependabot fixes, copy, CSS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants