Repository navigation
Release v2.5.1: version bump and changelog - #2254
Merged
Merged
Conversation
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/10/26/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/10/26/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
elifvish
reviewed
Oct 23, 2026
elifvish
left a comment
Collaborator
There was a problem hiding this comment.
Version numbers agree everywhere, and all seven PRs merge onto main cleanly. On the merged tree: PHPUnit 915/915, Jest 690/690 and build:prod all pass. Before tagging:
- Step 7 is still open: 25
@since n.e.x.tremain on the merged tree, and the POT needs the new strings. - The folder line in the changelog says "visible only to signed-in users"; reads actually need
edit_posts, and slugs still show inclass_listuntil #2244 is settled. Worth adjusting once that lands.
Verification
- Head tested:
4d606613e5(merged last, on top of the six fixes). - All seven 2.5.1 PRs merged onto
main(no conflicts): PHPUnit 915/915, Jest 690/690,build:prodOK. - Not covered: Step 7 (n.e.x.t replacement, POT regeneration) is not in the PR yet.
Screenshots and a recording of the local run are available on request.
… POT The POT is built from main with all six 2.5.1 fixes merged, so it matches once they land.
Collaborator
|
Review: Release v2.5.1 — approvable ✅ Verified the release mechanics:
Nit (non-blocking, pre-existing): LGTM to merge last, after the six fix PRs. |
KMchaudhary
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog for the 2.5.1 hotfix, into
main. Merge this last, after the six fix PRs below.Release steps
readme.txtandCHANGELOG.md; the third-last entry (v2.4.0) removed fromreadme.txt. Date set to October 23, 2026; change it if the release day is different.Stable taginreadme.txtis 2.5.1.Tested up tostays 7.1 (latest WordPress is 7.1.3).Stable taginREADME.mdis 2.5.1.godam.phpheader:Version: 2.5.1.godam.phpconstant:RTGODAM_VERSIONis2.5.1.package.jsonandpackage-lock.json(root version fields) are 2.5.1.@since n.e.x.twith2.5.1.mainhas none yet; the six PRs add 25. Done in this PR after they merge, together with the.potregeneration for their new strings.Changelog
What goes in 2.5.1
Together: all six merged onto
mainin one local branch (no conflicts): PHPUnit 916 tests OK,phpcsclean on all 60 changed PHP files,php -lclean, PHPCompatibility 7.4+ clean, hook checks clean. Plugin Check on every PR shows the same 13 warnings as the 2.5.0 release, so nothing new.What changed (release checklist)
Hooks, filters, routes, JS globals:
rtgodam_shortcode_output: still works, now throughapply_filters_deprecated(); replaced byrtgodam_shortcode_atts(Render the GoDAM player from attributes instead of a built shortcode string #2243).Media_Library::enforce_locked_media_folder()and itsrest_pre_dispatchhook: removed. The folder lock now sits on the media-folder routes' own permission checks,map_meta_cap,pre_insert_termandrest_pre_insert_attachment(Keep media folders private to signed-in users, and apply the folder lock on every route #2244). Not used by GoDAM for Woo.forms_permissions_check(): moved from the Gravity Forms class into the REST base class, same behaviour (Restrict the Media Editor's form routes to users who can open it #2252).rtgodam_can_view_attachment,rtgodam_shortcode_atts,godam_transcoder_verify_ssl.Data: no new tables, options or upgrade routines. One new post meta,
rtgodam_transcoding_status_updated, written when GoDAM sends a status update; videos without it just skip the short wait for a thumbnail. The transcoding status read no longer writesrtgodam_thumbnail_retry_count. Nothing to undo on rollback.After the release, check on a live site:
To back out: point
Stable tagback to 2.5.0, or ship 2.5.2.