Skip to content

Release v2.5.1: version bump and changelog - #2254

Merged
subodhr258 merged 2 commits into
mainfrom
chore/version-bump-2.5.1
Oct 26, 2026
Merged

subodhr258 merged 2 commits into
mainfrom
chore/version-bump-2.5.1

Conversation

@subodhr258

Copy link
Copy Markdown
Collaborator

Version bump and changelog for the 2.5.1 hotfix, into main. Merge this last, after the six fix PRs below.

Release steps

  • 1. Changelog with the date in readme.txt and CHANGELOG.md; the third-last entry (v2.4.0) removed from readme.txt. Date set to October 23, 2026; change it if the release day is different.
  • 2. Stable tag in readme.txt is 2.5.1. Tested up to stays 7.1 (latest WordPress is 7.1.3).
  • 3. Stable tag in README.md is 2.5.1.
  • 4. godam.php header: Version: 2.5.1.
  • 5. godam.php constant: RTGODAM_VERSION is 2.5.1.
  • 6. package.json and package-lock.json (root version fields) are 2.5.1.
  • 7. Replace @since n.e.x.t with 2.5.1. main has none yet; the six PRs add 25. Done in this PR after they merge, together with the .pot regeneration for their new strings.

Changelog

= v2.5.1 (October 23, 2026) =

- Fix: GoDAM's public video pages, lists and player data no longer show media from draft, private or scheduled posts. Media used on a published page keeps working.
- Fix: GoDAM only deletes, exports and stores media files that are inside the uploads folder.
- Fix: Video embed pages and form entries build the player from checked settings.
- Fix: The form lists in the video editor are available only to users who can upload media, and Jetpack forms in videos show only on published posts.
- Fix: Sending media to GoDAM for transcoding now checks GoDAM's security certificate.
- Fix: Media folders are visible only to signed-in users, and a locked folder stays locked everywhere.

What goes in 2.5.1

PR Change
#2245 Show media on GoDAM's public routes only where WordPress would show it
#2242 Only delete, export and store media files inside the uploads folder
#2243 Render the GoDAM player from attributes instead of a built shortcode string
#2252 Restrict the Media Editor's form routes to users who can open it
#2241 Verify the TLS certificate when sending media for transcoding
#2244 Keep media folders private to signed-in users, and apply the folder lock on every route

Together: all six merged onto main in one local branch (no conflicts): PHPUnit 916 tests OK, phpcs clean on all 60 changed PHP files, php -l clean, PHPCompatibility 7.4+ clean, hook checks clean. Plugin Check on every PR shows the same 13 warnings as the 2.5.0 release, so nothing new.

What changed (release checklist)

Hooks, filters, routes, JS globals:

Data: no new tables, options or upgrade routines. One new post meta, rtgodam_transcoding_status_updated, written when GoDAM sends a status update; videos without it just skip the short wait for a thumbnail. The transcoding status read no longer writes rtgodam_thumbnail_retry_count. Nothing to undo on rollback.

After the release, check on a live site:

  1. A published video plays in the player, gallery, lightbox and embed page.
  2. Upload a video: it transcodes and its status updates in the Media Library.
  3. Media Library folders load for an Author, and a locked folder can't be changed.
  4. The video editor's form layers list forms for each installed form plugin.
  5. A Jetpack form inside a video on a published post submits.

To back out: point Stable tag back to 2.5.0, or ship 2.5.2.

@subodhr258 subodhr258 self-assigned this Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
13 0 13

⚠️ Warnings (13)

📁 readme.txt (2 warnings)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM".
0 trademarked_term The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/10/26/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/10/26/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@elifvish elifvish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version numbers agree everywhere, and all seven PRs merge onto main cleanly. On the merged tree: PHPUnit 915/915, Jest 690/690 and build:prod all pass. Before tagging:

  • Step 7 is still open: 25 @since n.e.x.t remain on the merged tree, and the POT needs the new strings.
  • The folder line in the changelog says "visible only to signed-in users"; reads actually need edit_posts, and slugs still show in class_list until #2244 is settled. Worth adjusting once that lands.

Verification

  • Head tested: 4d606613e5 (merged last, on top of the six fixes).
  • All seven 2.5.1 PRs merged onto main (no conflicts): PHPUnit 915/915, Jest 690/690, build:prod OK.
  • Not covered: Step 7 (n.e.x.t replacement, POT regeneration) is not in the PR yet.

Screenshots and a recording of the local run are available on request.

… POT

The POT is built from main with all six 2.5.1 fixes merged, so it matches
once they land.
@KMchaudhary

Copy link
Copy Markdown
Collaborator

Review: Release v2.5.1 — approvable ✅

Verified the release mechanics:

Nit (non-blocking, pre-existing): Tested up to: 7.1 is unchanged from 2.5.0 — worth a glance that it's the intended value, but not part of this bump.

LGTM to merge last, after the six fix PRs.

@subodhr258
subodhr258 merged commit 9764639 into main Oct 26, 2026
10 of 11 checks passed
@subodhr258
subodhr258 deleted the chore/version-bump-2.5.1 branch October 26, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants