Repository navigation
Fix the minor bugs GoDAM plugin detected by Videojet team - #2085
Conversation
There was a problem hiding this comment.
Pull request overview
Moves the gallery modal close button outside the desktop video area while retaining an overlaid mobile layout.
Changes:
- Reserves vertical space above desktop videos for the close button.
- Adds responsive viewport sizing and iframe corner rounding.
- Repositions the mobile close button to the top-left.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (1)📁 readme.txt (1 error)
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 composer.json (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 assets/build/blocks/godam-gallery-v2/render.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
15 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$inner_block_video_ids". |
23 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$inner_block_video_ids". |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/08/20/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/08/20/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
|
Reviewed the full diff. No blocking issues from me, this looks good. Checked the substantive logic:
The two Copilot points on
Both are minor. Once those two are in, LGTM. |
…mprove modal height handling
subodhr258
left a comment
There was a problem hiding this comment.
Approving. Re-reviewed at 2242bf0b: both CSS points are correctly addressed — the close button is offset by max(0px, env(safe-area-inset-right) - 4vw) for notched landscape, and @supports (height: 100dvh) is added inside the mobile query so the full-screen modal clears browser chrome. Lightbox poster controls, the editor/Elementor dual-lock, and the transcript-precedence fix all check out, with good test coverage.
JS unit tests, PHP unit tests and PHPCS pass. The red POT and Plugin Check are the known pre-existing/expected ones, not caused by this PR.
This pull request makes several improvements to the "Show in lightbox" feature for GoDAM video blocks and Elementor controls, focusing on accessibility, UI consistency, and user experience. The main changes ensure that when a video is set to open in a lightbox, its inline poster state is visually and functionally correct, and that related controls are properly locked or restored as needed. The update also refines the modal's layout and improves the logic for disabling incompatible controls both in the block editor and Elementor.
Lightbox & Modal Behavior Improvements:
godam-gallery-v2-modal) now reserves vertical space above the iframe for the close button, ensuring the button is always visible and the modal remains centered regardless of viewport size. This includes support fordvhunits for better mobile compatibility.Player Poster and Control Handling:
vjs-has-startedflag for correct UI restoration. [1] [2] [3] [4] [5]Editor and Elementor Control Locking:
Testing and Maintainability:
These changes collectively enhance the reliability, accessibility, and user experience of the lightbox video feature across both the block editor and Elementor environments.
Demos
Gallery block


Hide the Lightbox player controls on lightbox get closed
Screen.Recording.2026-08-19.at.6.22.17.PM.mp4