fix: ignore autoplay attribute mutations regardless of tagName case - #1921
Open
roggernaut wants to merge 1 commit into
Open
fix: ignore autoplay attribute mutations regardless of tagName case#1921roggernaut wants to merge 1 commit into
roggernaut wants to merge 1 commit into
Conversation
ignoreAttribute compares the tag name against lowercase literals, but the attribute-mutation handler in rrweb passes the native uppercase target.tagName, so autoplay changes on video/audio elements were never ignored during live recording. Lowercase inside ignoreAttribute so the snapshot and mutation paths behave the same. Fixes rrweb-io#1916
🦋 Changeset detectedLatest commit: b28daba The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1916.
ignoreAttributecompares the tag name against lowercase['video', 'audio'], but the attribute-mutation handler inpackages/rrweb/src/record/mutation.tspasses the native uppercasetarget.tagName, soautoplaychanges on media elements were never ignored during live recording. This lowercases the tag name insideignoreAttribute, making the snapshot and mutation paths behave the same.Includes unit tests (the uppercase case fails without the fix) and a changeset.