Ensure we aren't adding extra newlines to failure output#1295
Open
synic wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, would be helpful if you could state why we need this? Do you want to use multiline issue messages? |
Author
|
@rrrene yes, we use multiline for a bunch of them (like you see in the example). Without the fix, every line is rewritten with an extra newline due to |
Owner
|
Got it. I am not necessarily against allowing multi-line issue messages, it just did not come up so far. Out of curiosity: why would you want to print a multi-paragraph explanation as a message, when there is also the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Bunt.writeinstead ofBunt.putsfor failure text output so we don't end up with extra newlinesBefore:
After: