Skip to content

Ensure we aren't adding extra newlines to failure output#1295

Open
synic wants to merge 1 commit into
rrrene:masterfrom
synic:synic/fix-credo-output-spacing
Open

Ensure we aren't adding extra newlines to failure output#1295
synic wants to merge 1 commit into
rrrene:masterfrom
synic:synic/fix-credo-output-spacing

Conversation

@synic

@synic synic commented Jun 17, 2026

Copy link
Copy Markdown

Use Bunt.write instead of Bunt.puts for failure text output so we don't end up with extra newlines

Before:

image

After:

image

@rrrene

rrrene commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Hi, would be helpful if you could state why we need this?

Do you want to use multiline issue messages?

@synic

synic commented Jun 18, 2026

Copy link
Copy Markdown
Author

@rrrene yes, we use multiline for a bunch of them (like you see in the example). Without the fix, every line is rewritten with an extra newline due to Bunt.puts adding it's own newline.

@rrrene

rrrene commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Got it. I am not necessarily against allowing multi-line issue messages, it just did not come up so far.

Out of curiosity: why would you want to print a multi-paragraph explanation as a message, when there is also the :explanations one can define for a check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants