[FEAT] Add namespaced CSRF token names - #33
Merged
Merged
Conversation
Prevent CSRF cookie collisions between services sharing a host. - Add configurable namespace-derived cookie and header names - Preserve legacy names by default - Support automatic namespacing through `Namespacer` - Skip CSRF validation for safe HTTP methods `GET`, `HEAD`, and `OPTIONS` - Add namespace, collision, validation, and compatibility tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of changes
Prevent CSRF cookie collisions between services sharing a host.
NewSecureTokenHandlerwhich defaults to host-only (prefix__HOST-) cookie namesNamespacerGET,HEAD, andOPTIONSFixes SC-40567
Type of change
Acceptance criteria
This PR will be merged without review.
Definition of Done