Skip to content

remove EventsExecutor explanation. - #6978

Merged
ahcorde merged 4 commits into
rollingfrom
fujitatomoya/remove-eventsexecutor
Jul 16, 2026
Merged

remove EventsExecutor explanation.#6978
ahcorde merged 4 commits into
rollingfrom
fujitatomoya/remove-eventsexecutor

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Description

aligns with ros2/rclcpp#3192

Fixes # (issue)

Did you use Generative AI?

Yes, Claude Opus 4.8

Additional Information

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fujitatomoya fujitatomoya self-assigned this Jul 15, 2026
@ahcorde
ahcorde requested a review from skyegalaxy July 15, 2026 07:18

@ahcorde ahcorde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters are failing

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

this is failing with rolling, i think @gbiggs just fixed that with 8cbecc2

@fujitatomoya
fujitatomoya requested a review from ahcorde July 16, 2026 05:48
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/29488442144/artifacts/8371557714.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-6978/index.html in your favorite browser

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

hmmm still failing, let me take a look.

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

https://github.com/ros2/ros2_documentation/actions/runs/29482254196/job/87569015357?pr=6978 still can be reproduced with rolling branch, some PRs have been merged with something broken...

WARNING: logo file 'source/Releases/rolling-small.png' does not exist

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

i think root cause is 7b786b2

@ahcorde
ahcorde merged commit 4557920 into rolling Jul 16, 2026
7 checks passed
@ahcorde
ahcorde deleted the fujitatomoya/remove-eventsexecutor branch July 16, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants