Skip to content

Enable ament_mypy (--ament-strict) on remaining Python demos - #801

Open
trippyogi wants to merge 1 commit into
ros2:rollingfrom
trippyogi:fix/765-ament-mypy
Open

Enable ament_mypy (--ament-strict) on remaining Python demos#801
trippyogi wants to merge 1 commit into
ros2:rollingfrom
trippyogi:fix/765-ament-mypy

Conversation

@trippyogi

Copy link
Copy Markdown

Summary

Related open PRs that this overlaps (can close if this lands): #780 (demo_nodes_py), #793 (quality_of_service_demo_py).

Fixes #765
Fixes #767
Fixes #769

Test plan

  • colcon build --packages-select demo_nodes_py quality_of_service_demo_py
  • colcon test --packages-select demo_nodes_py quality_of_service_demo_py --event-handlers console_cohesion+
  • Confirm test_mypy.py passes with --ament-strict on both packages
  • Confirm flake8/pep257/copyright/xmllint still pass
  • CI (Linux / aarch64 / RHEL / Windows) for rolling

Note: local validation was not run here (Windows host without a ROS 2 workspace); CI should validate ament_mypy.

Enable ament_mypy for demo_nodes_py and quality_of_service_demo_py and add type annotations so they pass with --ament-strict, completing the remaining packages for ros2#765.

Signed-off-by: Jeremy <peace@trippyogi.com>
@trippyogi

Copy link
Copy Markdown
Author

Overlap note

This draft overlaps existing open work:

Happy to close this in favor of those PRs, or slim this branch to only the QoS typing fixes if #793 lands the test hook first. Maintainer preference welcome.

@trippyogi

Copy link
Copy Markdown
Author

Still holding for maintainer scope decision

No intent to advance this draft over the assigned GFI PRs:

@trippyogi
trippyogi marked this pull request as ready for review August 3, 2026 22:37
@mergify

mergify Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this conflicts against #780 and #793, this conflicts need to be resolved.

and before review, please make sure that all the tests are pass with your code change in local environment.

@InvincibleRMC can you also take a look at this?

@trippyogi

Copy link
Copy Markdown
Author

Thanks @fujitatomoya, agreed. #801 was an exploratory combined draft; happy to close it so #780 (#767) and #793 (#769) stay the primary paths. If useful after those land, I can open a follow-up for any remaining QoS typing under --ament-strict. Open to take whichever direction you and @InvincibleRMC prefer.

@InvincibleRMC

Copy link
Copy Markdown
Contributor

I would close the other ones. And proceed with this one. Let me know once that is done and I can review it.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@InvincibleRMC i will leave this up to you, but #780 and #793 original authors are responsive reliably, so i would not want to just go ahead to close their effort on those PRs. i would take part of those PRs, and then come back on this PR what is left to address.

@InvincibleRMC

Copy link
Copy Markdown
Contributor

Sorry @fujitatomoya I agree with what you said. I mistakenly thought it was the same developer wanting to close their small PRS and join them into one larger one for less review churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ament_mypy to rclpy in quality_of_service_demo Add ament_mypy to demo_nodes_py Make demo python packages pass with ament_mypy

4 participants