Enable ament_mypy (--ament-strict) on remaining Python demos - #801
Enable ament_mypy (--ament-strict) on remaining Python demos#801trippyogi wants to merge 1 commit into
Conversation
Enable ament_mypy for demo_nodes_py and quality_of_service_demo_py and add type annotations so they pass with --ament-strict, completing the remaining packages for ros2#765. Signed-off-by: Jeremy <peace@trippyogi.com>
Overlap noteThis draft overlaps existing open work:
Happy to close this in favor of those PRs, or slim this branch to only the QoS typing fixes if #793 lands the test hook first. Maintainer preference welcome. |
Still holding for maintainer scope decisionNo intent to advance this draft over the assigned GFI PRs:
|
|
Tick the box to add this pull request to the merge queue (same as
|
fujitatomoya
left a comment
There was a problem hiding this comment.
i think this conflicts against #780 and #793, this conflicts need to be resolved.
and before review, please make sure that all the tests are pass with your code change in local environment.
@InvincibleRMC can you also take a look at this?
|
Thanks @fujitatomoya, agreed. #801 was an exploratory combined draft; happy to close it so #780 (#767) and #793 (#769) stay the primary paths. If useful after those land, I can open a follow-up for any remaining QoS typing under --ament-strict. Open to take whichever direction you and @InvincibleRMC prefer. |
|
I would close the other ones. And proceed with this one. Let me know once that is done and I can review it. |
|
@InvincibleRMC i will leave this up to you, but #780 and #793 original authors are responsive reliably, so i would not want to just go ahead to close their effort on those PRs. i would take part of those PRs, and then come back on this PR what is left to address. |
|
Sorry @fujitatomoya I agree with what you said. I mistakenly thought it was the same developer wanting to close their small PRS and join them into one larger one for less review churn. |
Summary
ament_mypy+test/test_mypy.pywith--ament-strictfordemo_nodes_pyandquality_of_service_demo_py(remaining packages under Make demo python packages pass withament_mypy#765 / Addament_mypytodemo_nodes_py#767 / Addament_mypytorclpyinquality_of_service_demo#769).main/__init__return types).liveliness.py, align the publisher liveliness callback withQoSLivelinessLostInfofields (total_count/total_count_change) instead of subscription liveliness-changed fields.Related open PRs that this overlaps (can close if this lands): #780 (
demo_nodes_py), #793 (quality_of_service_demo_py).Fixes #765
Fixes #767
Fixes #769
Test plan
colcon build --packages-select demo_nodes_py quality_of_service_demo_pycolcon test --packages-select demo_nodes_py quality_of_service_demo_py --event-handlers console_cohesion+test_mypy.pypasses with--ament-stricton both packagesNote: local validation was not run here (Windows host without a ROS 2 workspace); CI should validate ament_mypy.