Include noetic build in CI

[stwirth]

• Makes CI build for noetic as well
• Adds some missing #includes
• Simplifies the download_spinnaker script and makes it download a newer version of the SDK for noetic
• Removes the "install" step from the build: I would suggest everyone to install the official Spinnaker SDK when using this driver, so this auto-downloading feature is just used for CI and development workspaces.

[stwirth]

Seems the CI doesn't like

#!/usr/bin/env python

Maybe the script should be ported to python3? Should still work fine for kinetic/xenial.

[stwirth]

Clearpath seems to host the 2.2.0.48 version of the Spinnaker SDK on https://packages.clearpathrobotics.com/stable/flir/Spinnaker/Ubuntu20.04/. The download_spinnaker script would need to be adapted to pull from there. The version specified there (1.27.0.48) does not seem to be published by FLIR for Ubuntu 20.04.

[stwirth]

Still a little more work needed to match download_spinnaker and DownloadSpinnaker.cmake.

[stwirth]

Last noetic build went through but kinetic and melodic failed with:

make[2]: *** No rule to make target 'spinnaker-sdk/usr/lib/libSpinnaker.so', needed by '/root/target_ws/devel/.private/spinnaker_camera_driver/lib/libSpinnakerCameraLib.so'.  Stop.

Took me almost a day to find out that this is caused by a broken symbolic link in the spinnaker debians version 1.27.0.48. 🤯

[stwirth]

@mhosmar-cpr this is ready for review.

[stwirth]

@mhosmar-cpr ping

[Jaeyoung-Lim]

@stwirth @mhosmar-cpr Any reason that this is not getting in?

[stwirth]

@stwirth @mhosmar-cpr Any reason that this is not getting in?

Not from my side, this is waiting for comment/merge from a maintainer.

[ghost]

Looks like we're not bundling the sdk anymore. Do we not need this for the deb?

[stwirth]

I'm pretty sure that license agreement is outdated (there is no flycapture / pointgrey anymore, it's Spinnaker / FLIR now) and I think it is better to let the users install the SDK by themselves. We could try to make a separate ROS package that just catkinizes the Spinnaker SDK but I won't have time for that. The official way of installing the SDK also includes an explicit manual confirmation of the license.

So my suggestion is to use the download script just for CI and encourage the user to use this package from source.
Any better ideas?