fix: make select.web consistent#57
Open
bryanmylee wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Added another fix to solve #58. |
mrzachnugent
requested changes
Feb 4, 2025
mrzachnugent
left a comment
mrzachnugent
left a comment
Collaborator
There was a problem hiding this comment.
@bryanmylee Thanks for another contribution.
For each `<Item>` component, keep track of its `value` to `label`
mapping on the `<Root>` component by passing a `MutableRefObject`
that stores the mapping from `<Root>` to `<Item>` via context.
On render, `<Item>` sets the label for its value. `<Root>` can then call
`onValueChange` with `labelForValueRef.current[val] ?? val`, allowing
feature parity with the native implementation.
This approach works perfectly. Since `Item` must be rendered before it
can be interacted with and emit events, this always ensures that
`labelForValueRef[val]` exists before `onStrValueChange` is called.
Furthermore, since the `value` and `defaultValue` prop requires `{
value: string, label: string }`, the initial render also does not have
any issues.
bryanmylee
force-pushed
the
fix-select-label-consistency
branch
from
February 4, 2025 15:00
408e728 to
f771f8f
Compare
Contributor
Author
|
|
|
hi, any updates on this? |
|
Any updates on this? Why not make the other way around and change the Option to be a string instead of { value: string, label: string }? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #26 in making the
<Select>component consistent on web and native.For each
<Item>component, keep track of itsvaluetolabelmapping on the<Root>component by passing aMutableRefObjectthat stores the mapping from<Root>to<Item>via context.On render,
<Item>sets the label for its value.<Root>can then callonValueChangewithlabelForValueRef.current[val] ?? val, allowing feature parity with the native implementation.This approach works perfectly. Since
Itemmust be rendered before it can be interacted with and emit events, this always ensures thatlabelForValueRef[val]exists beforeonStrValueChangeis called. Furthermore, since thevalueanddefaultValueprop requires{ value: string, label: string }, the initial render also does not have any issues.