Skip to content

Update SSD/NVMe specific wipe approach (#593) - #594

Merged
phillxnet merged 2 commits into
rockstor:masterfrom
Hooverdan96:add_wipe_SSD_NVMe
May 6, 2026
Merged

phillxnet merged 2 commits into
rockstor:masterfrom
Hooverdan96:add_wipe_SSD_NVMe

Conversation

@Hooverdan96

Copy link
Copy Markdown
Member

To ease and accelerate the PR submission, please use the template below to provide all required information.
Please see our "Contributing to Rockstor documentation" in our Rockstor's documentation

Fixes #593.

This pull request's proposal

Add the recently included NVMe/SSD wipe approach into the rockstor documentation. I am linking to the overall documentation, because the authors of ShredOS are planning on introducing it as part of the UI, but the first iteration relies on the command line, which they describe in a sub-section of the Readme. If/when that section changes (or gets restructured, then the link doesn't have to be immediately updated.

Otherwise, I can of course directly link to the current chapter for this topic.

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

@phillxnet

Copy link
Copy Markdown
Member

@Hooverdan96 Sorry but I built and reviewed this with a request to add a full stop at the end of the first sentence of the note; but alas GitHub is poorly and so refused to accept it. Hopeing a regular comment will work.

PR594-ssd_and_nvme-note

@Hooverdan96

Copy link
Copy Markdown
Member Author

Yes, I see it. Even with semantic formatting, I overlook these pesky little periods occasionally. Thanks for your eagle eyes.

@phillxnet phillxnet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 Thanks again for seeing to this. And getting that full-stop in there :).

I'll merge and get this published shortly.

@phillxnet
phillxnet merged commit 159c36b into rockstor:master May 6, 2026
2 of 3 checks passed
@phillxnet

Copy link
Copy Markdown
Member

PRODUCTION published.

@Hooverdan96
Hooverdan96 deleted the add_wipe_SSD_NVMe branch May 6, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SSD/NVMe wipe notes

2 participants