fix(web): restore Web Push delivery on Node 22 and 24 - #623
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Node uses the all-address DNS lookup callback when autoSelectFamily is enabled. The pinned Web Push transport returned the legacy single-address callback shape, so every request failed locally with ERR_INVALID_IP_ADDRESS before reaching Apple. Subscription and permission setup were working.
Change
Honor both Node lookup callback forms while still returning only the one public address selected by endpoint validation. Add a real TCP regression test that exercises the autoSelectFamily path.
CI environment note
The Node 24 verification lane is temporarily pinned to 24.18.0. Node 24.19.0 has a confirmed ObjectWrap teardown regression that aborts native addons such as better-sqlite3; nodejs/node#65042 is the upstream backport. The workflow contract test covers the temporary pin.
Verification
Node 22.19.0 focused Web Push tests: 15 passed.
Node 24.15.0 focused Web Push tests: 15 passed.
Web package server tests: 133 passed.
Webapp tests: 202 passed.
Repository verify:all: green.
CI workflow contract tests: 31 passed.
Follow-up to #614.