Repository navigation
Conversation
The scraper already searches by postcode but then needed the UPRN to choose from the address list. When no UPRN is given it now picks the address by house number from that same list. Adds request timeouts.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2320 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 43 43
Lines 3380 3380
=======================================
Hits 2825 2825
Misses 555 555 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Belfast already posts the postcode to
Default.aspx, and the response contains the full address list (lstAddresses) with UPRNs as the option values, but the scraper still needed the UPRN passed in to choose one. When no UPRN is given it now picks the address from that list by house number, so postcode + house number works without looking up a UPRN anywhere else.ValueErrorinstead of choosing the first addresstimeout=30to the three requestsTesting
BT5 5LY+63picks185023941(63 Martinez Avenue), 3 collections returnedBT10 0GY+185086469, 4 collections returned