Skip to content

fix: tighten south lanarkshire address matching - #2311

Open
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/south-lanarkshire-address-match
Open

InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:fix/south-lanarkshire-address-match

Conversation

@InertiaUK

Copy link
Copy Markdown
Contributor

Summary

The paon match used startswith, so "1" would pick "10 ..." if it came first in the dropdown. It now uses a word-boundary match, which also copes with flat labels like "0-1, 21 Victoria St", and skips the "I cannot find my property" option (value 111111).

Also accepts house_number as well as paon, adds timeout=30 and raise_for_status(), and raises a ValueError when no dates are found.

Testing

  • G74 5DQ (input.json): 4 collections
  • G73 3PU / 2: 4 collections

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 77b32995-44e6-46ce-86f7-bf1446db89ff
Commits

Reviewing files that changed from the base of the PR and between 0d1b26a and 5b3283d.

Files selected for processing: 1
  • uk_bin_collection/uk_bin_collection/councils/SouthLanarkshireCouncil.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.18%. Comparing base (0d1b26a) to head (5b3283d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bin_collection/councils/SouthLanarkshireCouncil.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
- Coverage   83.57%   82.18%   -1.40%     
==========================================
  Files          43       43              
  Lines        3380     3390      +10     
==========================================
- Hits         2825     2786      -39     
- Misses        555      604      +49     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant