You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
WhiffStats.beaten_to_ball_count stays at 0 since beaten-to-ball moved to its own detector #284
Since #280, whiff detection no longer emits WhiffEventKind::BeatenToBall,
and the detector added in #278 only produces BeatenToBallEvents. Nothing
accumulates those events, so WhiffStats.beaten_to_ball_count is always 0
for new replays, and there's no other per-player beaten-to-ball count.
Is that intended? We show the count as a per-player stat, so it would help
to know which direction you have in mind:
The whiff accumulator counts the detector's events into beaten_to_ball_count. That's what we do in our fork for now: wilbo@5922cd1
A dedicated beaten-to-ball stats module, retiring the field on WhiffStats.
Activity