Skip to content

Added new apis for CutterDiff: rz_unified_diff_grouped and rz_diff_op_stringify#6614

Open
NewtronReal wants to merge 3 commits into
rizinorg:devfrom
NewtronReal:diffopstringify
Open

Added new apis for CutterDiff: rz_unified_diff_grouped and rz_diff_op_stringify#6614
NewtronReal wants to merge 3 commits into
rizinorg:devfrom
NewtronReal:diffopstringify

Conversation

@NewtronReal

@NewtronReal NewtronReal commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

cleanup

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Added two new apis for passing RzDiffOp groups(with binarydiffing selector) to cutter and stringifying specific RzDiffOp independently. Seperated fill char bounds from the main function.

Added necessary test cases.
...

Test plan
Passes test_rz_diff_op_stringify in tests.

...

Closing issues

None

...

@NewtronReal NewtronReal changed the title Added new apis for CutterDiff and rz-diff fixes for functions. Added new apis for CutterDiff: rz_unified_diff_grouped and rz_diff_op_stringify Jul 11, 2026
@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.96%. Comparing base (d2d6846) to head (76f4a38).

Files with missing lines Patch % Lines
librz/diff/unified_diff.c 79.68% 4 Missing and 9 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/cons/pal.c 65.26% <100.00%> (+0.18%) ⬆️
librz/core/cmd_descs/cmd_descs.c 50.63% <ø> (ø)
librz/diff/unified_diff.c 79.37% <79.68%> (-0.32%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d6846...76f4a38. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NewtronReal NewtronReal force-pushed the diffopstringify branch 2 times, most recently from b2e38db to 0651faf Compare July 11, 2026 17:21
@NewtronReal NewtronReal force-pushed the diffopstringify branch 2 times, most recently from 39d5a80 to 092cdd6 Compare July 11, 2026 19:05
cleanup

Cleanup

Cleanup

Format fix
chaged test files
@wargio

wargio commented Jul 13, 2026

Copy link
Copy Markdown
Member

you should maybe change the original code to use this function too. after all it's an extract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants