Fix m680x instruction mappings#6609
Open
historicattle wants to merge 1 commit into
Open
Conversation
Make the CPU mode checks case insensitive
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
notxvilka
approved these changes
Jul 8, 2026
Contributor
Author
wargio
reviewed
Jul 14, 2026
| } else if (str && strstr(str, "68HC08")) { | ||
| } else if (rz_str_casestr(str, "68hc08")) { | ||
| return CS_MODE_M680X_6808; | ||
| } else if (str && strstr(str, "6809")) { |
Member
There was a problem hiding this comment.
extract this function and move it into arch_m680x_cs.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
m680xmode()to correctly returnCS_MODE_M680X_HCS12Xinstead of returningRZ_CAPSTONE_HAS_M680X_HCS12XTest plan
Updated the test in
test/db/analysis/m680xsinceM680X_INS_JSRis correctly classified as aRZ_ANALYSIS_OP_TYPE_CALLClosing issues
Partially addresses #5933