Skip to content

Fix memory leaks in arch and core#6590

Merged
notxvilka merged 1 commit into
devfrom
asan-leak-fixes
Jul 4, 2026
Merged

Fix memory leaks in arch and core#6590
notxvilka merged 1 commit into
devfrom
asan-leak-fixes

Conversation

@notxvilka

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Fix more leaks found in #6578

Test plan

CI is green

Comment thread librz/arch/isa/8051/8051_parse.c Outdated
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.92%. Comparing base (ff4d660) to head (e15a51e).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
librz/arch/isa/8051/8051_parse.c 71.42% 2 Missing and 2 partials ⚠️
librz/bin/pdb/symbol.c 0.00% 2 Missing ⚠️
librz/bin/pdb/gdata.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/arch/isa/8051/8051_il.c 78.81% <100.00%> (ø)
librz/arch/isa/sh/sh_il.c 91.87% <100.00%> (ø)
librz/arch/pdb_process.c 64.39% <100.00%> (+0.17%) ⬆️
librz/core/cmd/cmd_debug.c 27.67% <100.00%> (+0.06%) ⬆️
librz/bin/pdb/gdata.c 48.14% <66.66%> (+4.14%) ⬆️
librz/bin/pdb/symbol.c 49.71% <0.00%> (-0.57%) ⬇️
librz/arch/isa/8051/8051_parse.c 85.31% <71.42%> (-0.57%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4d660...e15a51e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread librz/arch/isa/sh/sh_il.c Outdated
Comment thread librz/arch/isa/8051/8051_parse.c Outdated
@notxvilka
notxvilka merged commit 84b2f31 into dev Jul 4, 2026
54 of 55 checks passed
@notxvilka
notxvilka deleted the asan-leak-fixes branch July 4, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants