You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've documented every RZ_API function and struct this PR changes.
I've added tests that prove my changes are effective (required for changes to RZ_API).
I've updated the Rizin book with the relevant information (if needed).
I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.
Detailed description
Introduced a variable space which shows the usable width for ticks — data_cols - addr_w, so the last tick's label doesn't overflow past the right edge (falls back to 1 if the chart's too narrow).
These kind of tests fail so weirdly because they differ in the escaped bytes.
You can download the full test log and check the byte content to your local one with rz-diff to see what escaped bytes differ.
❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.00%. Comparing base (a57652c) to head (eaf2429). ⚠️ Report is 1 commits behind head on dev.
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI/LLMPartially or fully AI generated. Critical thinking is advised!rz-testRzCons
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Introduced a variable
spacewhich shows the usable width for ticks —data_cols-addr_w, so the last tick's label doesn't overflow past the right edge (falls back to 1 if the chart's too narrow)....
Test plan


Before
After
...
Closing issues
closes #6550
...