Skip to content

Fix x-axis address overflow#6563

Open
Farhan-25 wants to merge 7 commits into
rizinorg:devfrom
Farhan-25:hist_addr_overflow
Open

Fix x-axis address overflow#6563
Farhan-25 wants to merge 7 commits into
rizinorg:devfrom
Farhan-25:hist_addr_overflow

Conversation

@Farhan-25

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Introduced a variable space which shows the usable width for ticks — data_cols - addr_w, so the last tick's label doesn't overflow past the right edge (falls back to 1 if the chart's too narrow).

...

Test plan
Before
image
After
image

...

Closing issues

closes #6550

...

@Rot127

Rot127 commented Jun 27, 2026

Copy link
Copy Markdown
Member

Check tests please

@Rot127

Rot127 commented Jul 16, 2026

Copy link
Copy Markdown
Member

These kind of tests fail so weirdly because they differ in the escaped bytes.
You can download the full test log and check the byte content to your local one with rz-diff to see what escaped bytes differ.

@Farhan-25

Copy link
Copy Markdown
Contributor Author

Yes i got a way to fix them rz-test -i -C will push the correct commit in just a min.

@github-actions github-actions Bot added the AI/LLM Partially or fully AI generated. Critical thinking is advised! label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.00%. Comparing base (a57652c) to head (eaf2429).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
librz/cons/histogram.c 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/cons/histogram.c 69.58% <50.00%> (-0.37%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57652c...eaf2429. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI/LLM Partially or fully AI generated. Critical thinking is advised! rz-test RzCons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address in interactive histogram overflows.

2 participants