Skip to content

docs(container-runner): sync deploy docs with runner source - #5557

Open
abcxff wants to merge 1 commit into
stack/fix-container-runner-read-cgroup-v1-memory-usage-on-gen1-gvisor-qyxytrmlfrom
stack/docs-container-runner-sync-deploy-docs-with-runner-source-nxplusuw
Open

docs(container-runner): sync deploy docs with runner source#5557
abcxff wants to merge 1 commit into
stack/fix-container-runner-read-cgroup-v1-memory-usage-on-gen1-gvisor-qyxytrmlfrom
stack/docs-container-runner-sync-deploy-docs-with-runner-source-nxplusuw

Conversation

@abcxff

@abcxff abcxff commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review

Docs-only change syncing website/src/content/docs/deploy/container-runner.mdx with the current container-runner source. I cross-checked every changed value against container-runner/src/main.rs and container-runner/src/input.rs:

  • --stop-grace-secs default 2510: matches default_value_t = 10 on stop_grace_secs (main.rs:290).
  • New RIVET_SIGTERM_BUDGET_SECS row (default 10): matches SIGTERM_BUDGET's unwrap_or(10) (main.rs:111-118), and the description ("splits this budget across the engine drain, the child stop grace, and a straggler sweep") accurately reflects signal_drain_timeout (60%), signal_child_stop_grace (40%), and SIGNAL_SWEEP_GRACE (main.rs:120-128).
  • New input.port field and its description ("overrides the child's listen port ... falling back to --child-port when omitted") matches the ActorInput.port doc comment in input.rs verbatim.
  • The wording change from "Capped to a few seconds" → "Capped to a fraction of the platform's SIGTERM budget" is a more precise and still-correct description of effective_stop_grace().

No functional code is touched, and the doc text follows the house style (no em dashes, complete sentences). Nothing to flag — this is a straightforward, well-verified accuracy fix.

@abcxff
abcxff force-pushed the stack/fix-container-runner-read-cgroup-v1-memory-usage-on-gen1-gvisor-qyxytrml branch from a9d2805 to c5a71c8 Compare August 10, 2026 22:09
@abcxff
abcxff force-pushed the stack/docs-container-runner-sync-deploy-docs-with-runner-source-nxplusuw branch from 5e56ad0 to 4448b01 Compare August 10, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant