-
Notifications
You must be signed in to change notification settings - Fork 187
feat: conditional formatting for pivot tables #9668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7de9b38
feat: conditional formatting for pivot tables
nishantmonu51 80d1951
add rule formatting and stateful url
djbarnwal 20997e9
add conditional formatting in canvas measure chips
djbarnwal 03b043d
merge main
djbarnwal 3acde09
use lower is better instead of reverse color
djbarnwal 7f15a89
fix nested row rendering
djbarnwal d61ae35
fix hover color for formatted cells
djbarnwal 7e77c18
update popover style
djbarnwal 9f28923
prettier fix
djbarnwal 26e52bb
reset conditional formatting on metrics view change, preserve it on t…
nishantmonu51 c241bb3
guard malformed conditional_format YAML, let selection backgrounds ov…
nishantmonu51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
web-common/src/features/canvas/components/pivot/conditional-format.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { | ||
| conditionalFormatSpecToMeasureFormatting, | ||
| measureFormattingToConditionalFormatSpec, | ||
| type PivotConditionalFormatSpec, | ||
| } from "./index"; | ||
|
|
||
| describe("conditionalFormatSpecToMeasureFormatting", () => { | ||
| it("maps heatmap, data bar and rule specs per measure", () => { | ||
| const specs: PivotConditionalFormatSpec[] = [ | ||
| { measure: "revenue", mode: "heatmap", scheme: "red-green" }, | ||
| { measure: "cost", mode: "data_bar" }, | ||
| { | ||
| measure: "margin", | ||
| mode: "rules", | ||
| rules: [{ operator: "gt", value: 0, color: "green" }], | ||
| }, | ||
| ]; | ||
| expect(conditionalFormatSpecToMeasureFormatting(specs)).toEqual({ | ||
| revenue: { mode: "heatmap", scheme: "red-green" }, | ||
| cost: { mode: "data_bar", scheme: "theme-sequential" }, | ||
| margin: { | ||
| mode: "rules", | ||
| rules: [{ operator: "gt", value: 0, color: "green" }], | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| // The canvas YAML is hand-editable, so malformed values must be skipped | ||
| // instead of crashing the canvas. | ||
| it("returns empty formatting when the field is not an array", () => { | ||
| for (const bad of [undefined, null, 5, "heatmap", { measure: "revenue" }]) { | ||
| expect(conditionalFormatSpecToMeasureFormatting(bad as never)).toEqual( | ||
| {}, | ||
| ); | ||
| } | ||
| }); | ||
|
|
||
| it("skips entries that are not objects or lack a measure name", () => { | ||
| const specs = [ | ||
| null, | ||
| "revenue", | ||
| { mode: "heatmap" }, | ||
| { measure: "revenue", mode: "heatmap" }, | ||
| ]; | ||
| expect(conditionalFormatSpecToMeasureFormatting(specs as never)).toEqual({ | ||
| revenue: { mode: "heatmap", scheme: "theme-sequential" }, | ||
| }); | ||
| }); | ||
|
|
||
| it("skips rules specs whose rules are not a non-empty array of objects", () => { | ||
| const specs = [ | ||
| { measure: "a", mode: "rules", rules: "gt 5" }, | ||
| { measure: "b", mode: "rules", rules: [] }, | ||
| { measure: "c", mode: "rules", rules: [null, "x"] }, | ||
| { | ||
| measure: "d", | ||
| mode: "rules", | ||
| rules: [null, { operator: "gt", value: 0, color: "green" }], | ||
| }, | ||
| ]; | ||
| expect(conditionalFormatSpecToMeasureFormatting(specs as never)).toEqual({ | ||
| d: { | ||
| mode: "rules", | ||
| rules: [{ operator: "gt", value: 0, color: "green" }], | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| it("falls back to the default scheme for non-string schemes", () => { | ||
| const specs = [{ measure: "a", mode: "heatmap", scheme: 3 }]; | ||
| expect(conditionalFormatSpecToMeasureFormatting(specs as never)).toEqual({ | ||
| a: { mode: "heatmap", scheme: "theme-sequential" }, | ||
| }); | ||
| }); | ||
|
|
||
| it("round-trips through measureFormattingToConditionalFormatSpec", () => { | ||
| const specs: PivotConditionalFormatSpec[] = [ | ||
| { measure: "revenue", mode: "heatmap", scheme: "red-green" }, | ||
| { | ||
| measure: "margin", | ||
| mode: "rules", | ||
| rules: [{ operator: "between", value: 0, value2: 10, color: "blue" }], | ||
| }, | ||
| ]; | ||
| expect( | ||
| measureFormattingToConditionalFormatSpec( | ||
| conditionalFormatSpecToMeasureFormatting(specs), | ||
| ), | ||
| ).toEqual(specs); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.