Repository navigation
Conversation
Nested reusable workflows now call their siblings as `./.github/workflows/<file>.yml`, which GitHub resolves to the same commit as the calling workflow, also for callers in other repositories. A step-level local path resolves against the caller's checkout instead, so the steps of both composite actions are inlined into the workflows that used them. `scripts/check-inlined-steps` keeps the copies identical, and a new lint step rejects any `uses:` of this repository by tag. knope no longer rewrites workflow files at release time. BREAKING CHANGE: the composite actions `actions/setup-rust` and `actions/reset-changelogs` are removed. Call `rust-ci.yml`, `rust-cli-build.yml`, or `rust-integration-tests.yml` instead of `actions/setup-rust`, or copy its inlined steps; `prepare-release.yml` and `prepare-prerelease.yml` reset changelogs themselves. Tags up to `v0.4.10` still contain both actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz6m3aZBokQhgvfjnSv
BatmanAoD
force-pushed
the
remove-self-pins
branch
from
November 12, 2026 18:37
13882da to
1553bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every self-pin (
uses: rigetti/qcs-gha-infrastructure/...@vX.Y.Z) from the repository,so a release no longer has to rewrite workflow files in the commit its tag points at.
agent-choices.mdrecords the assumptions and choices made while preparing this change. Delete it before merging.Basis
Verified with a cross-repository caller in
https://github.com/BatmanAoD/gha-experiments-consumer/actions/runs/43278803558:
outer.yml@v1, whereouter.ymlcallsuses: ./.github/workflows/inner.yml,runs
inner.ymlfrom the same repository and the same commit asouter.yml(tag
v1, notmain).This matches GitHub's documentation:
"the called workflow is from the same commit as the caller workflow".
uses: ./actions/helloinside the called workflowresolves against the consumer's checkout.
So a reusable workflow here cannot use a local composite action.
Limits still apply: at most 10 nesting levels and 50 unique reusable workflows;
secrets and permissions are passed per level, and permissions can only narrow.
Changes
rust-cli-release.ymlandrust-cli-prerelease.ymlnow use
./.github/workflows/<file>.yml.actions/setup-rustandactions/reset-changelogsare removed.Their steps are inlined into each workflow that used them
(
rust-ci.yml×3,rust-cli-build.yml,rust-integration-tests.yml;prepare-release.yml,prepare-prerelease.yml),with third-party SHA pins and version comments unchanged.
The setup-rust copies read their inputs from job-level
SETUP_RUST_*variables,so all copies are byte-identical.
The unused sccache path was dropped (no workflow exposed it).
A
gh search codeacross therigettiorg found no callers outside this repository.scripts/check-inlined-steps(run bylint) fails when inlined copies drift apart.lintstep fails if anything under.github/(oractions/, should it return)contains
uses: rigetti/qcs-gha-infrastructure/.It replaces the step that required each self-pinning file to be listed in
knope.toml.Another new step rejects a step-level
uses: ./...other than./.github/workflows/.ci.yml'ssetup-rustjob runs the inlined steps;its
reset-changelogsjob extracts the script fromprepare-release.ymland runs the same three cases.knope.tomlversioned_fileskeeps only the README badge.dependabot.ymlscans/only.and the "Bumping this repository's own tag" section by "Nested workflows".
macos-14→macos-latest: nothing left to do, #23 is already onmain.Release and compatibility
refactor!with aBREAKING CHANGE:footer, so knope should releasev0.5.0.release.ymlflow, as before;there are no internal pins left for it to rewrite.
v0.4.10or earlier are unaffected:those tags keep their self-pins and their
actions/directory.(
release.ymlalready calls./.github/workflows/prepare-release.yml),so on this PR every local path resolves to the PR commit.
Validation
yqparses every workflow.scripts/*and on all 50run:blocks extracted from the workflows.scripts/check-inlined-stepspasses locally (jq-wrapperyq),and fails with the expected three errors on a deliberately mutated copy.
mainbefore the change and none after.release --dry-run, in a scratch Git repository withmaintaggedv0.4.10plus this commit:proposes
v0.5.0, touching onlyREADME.mdandCHANGELOG.md.lintjob runs it.release / prepare-releasecheck fails at checkout (could not read Username for 'https://github.com').It fails identically on
mainand on every pull request since 2026-11-12 16:30 UTC,so it is unrelated to this change; most likely
RELEASE_TOKENis expired or revoked.CI gatedoes not depend on it.their findings on
scripts/check-inlined-stepsrobustness and README wording are fixed.🤖 Generated with Claude Code
https://claude.ai/code/session_01K3mkz6m3aZBokQhgvfjnSv