VM: Double switch statement speed by not emitting the ranges dispatch if there are no range cases - #1165
Open
schungx wants to merge 2 commits into
Open
VM: Double switch statement speed by not emitting the ranges dispatch if there are no range cases#1165schungx wants to merge 2 commits into
schungx wants to merge 2 commits into
Conversation
ImTheSquid
reviewed
Sep 13, 2026
schungx
force-pushed
the
vm-optimize-switch
branch
2 times, most recently
from
September 14, 2026 07:20
c407bdb to
5afa2fb
Compare
Collaborator
Author
|
@ImTheSquid I have re-architect the PR. The push to Instead, the The compiler only emits a pop at the end of the The only tricky aspect is that those "stack surpluses" must also be popped if there is a |
schungx
force-pushed
the
vm-optimize-switch
branch
from
September 15, 2026 00:31
5afa2fb to
858ada2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple optimization for the
switchstatement.Currently, a single
switchstatement lowers into two calls toOp::Switch-- one for the cases and one for the ranges.In the predominant scenario of no range cases, there is no need to emit the dispatch to empty ranges.
This PR optimizes the lowering such that no second dispatch is emitted if there are no range cases. It also saves the push and pop of the
Scopeby not storing theswitchvalue.Speed of the
switchstatement doubles to close to 2x the speed of the AST walker when there are no range cases.