VM: Route map property read/write using Rhai similar to indexing. - #1164
Merged
Conversation
schungx
added
regression
vm
schungx
force-pushed
the
vm-revise-walk-property
branch
3 times, most recently
from
September 9, 2026 13:37
a841d2c to
c34479f
Compare
schungx
force-pushed
the
vm-revise-walk-property
branch
from
September 10, 2026 05:38
c34479f to
718c81d
Compare
ImTheSquid
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, Grain rolls its own indexing and property get/set logic.
Then indexing was rerouted to Rhai's standard
get_indexed_mutfunction that properly handles a range of special situations, such as theEngine::on_invalid_array_indexcallback.This PR routes also the property read/write process to Rhai, thus properly handling missing properties and the
Engine::on_map_missing_propertycallback.