[worker][refactor] change rpc handlers to return their next steps instead of taking actions inline#5043
Open
MohamedBassem wants to merge 1 commit into
Open
[worker][refactor] change rpc handlers to return their next steps instead of taking actions inline#5043MohamedBassem wants to merge 1 commit into
MohamedBassem wants to merge 1 commit into
Conversation
MohamedBassem
force-pushed
the
pr5043
branch
6 times, most recently
from
July 15, 2026 11:39
c27728d to
894af8b
Compare
MohamedBassem
marked this pull request as ready for review
July 15, 2026 11:39
…tead of taking actions inline As part of the work on centeralizes writes to the self proposer inside one scheduler, this PR refactors the RPC handlers to return their decisions to the main PP loop where they get executed there. This is in prep for shipping the proposals to a channel in the next PR. This PR is mostly mechanical and does the following: 1. Changes the handlers to no longer take the "Actuator" trait and instead return their `Decision` from the function. 2. The decision can be either: Propose a command (with its different modes), reply now, or the pre-vqueues invoker poking. Tests are much simpler as they no longer need to mock the leadership state. Only meaningful change was a bug in the restart_as_new test `copy_prefix_zero_with_no_version_uses_service_invocation_command` where it was using the default `patch_deployment_id` and it didn't actually hit the assertions inside the mock handlers as it was failing with `CannotPatchDeploymentId`. The tests where not setting expectations on num calls to the mock, so it didn't fail when the call to `append_and_respond_asynchronously` didn't happen. So this was fixed along the way by using `PatchDeploymentId::PinToLatest` to hit the correct assertions. This PR anyways removes `mockall` altogether from that worker crate.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the work on centeralizes writes to the self proposer inside one scheduler, this PR refactors the RPC handlers to return their decisions to the main PP loop where they get executed there. This is in prep for shipping the proposals to a channel in the next PR.
This PR is mostly mechanical and does the following:
Decisionfrom the function.Tests are much simpler as they no longer need to mock the leadership state. Only meaningful change was a bug in the restart_as_new test
copy_prefix_zero_with_no_version_uses_service_invocation_commandwhere it was using the defaultpatch_deployment_idand it didn't actually hit the assertions inside the mock handlers as it was failing withCannotPatchDeploymentId. The tests where not setting expectations on num calls to the mock, so it didn't fail when the call toappend_and_respond_asynchronouslydidn't happen. So this was fixed along the way by usingPatchDeploymentId::PinToLatestto hit the correct assertions. This PR anyways removesmockallaltogether from that worker crate.Stack created with Sapling. Best reviewed with ReviewStack.