wip-poc: connect-rpc scafolding#5026
Draft
muhamadazmy wants to merge 2 commits into
Draft
Conversation
Summary: A seed for the ingestion protocol protobuf.
Summary: Experiment with connect-rpc since it support streaming over http2 and http1 (connect protocol)
| tracing-test = { workspace = true } | ||
|
|
||
| [build-dependencies] | ||
| connectrpc-build = { version = "0.8" } |
Member
There was a problem hiding this comment.
please tell me that we are not going to pull prost+buffa+bilrost+flexbuffers in the same project :)
Contributor
Author
There was a problem hiding this comment.
No, don't worry. I am trying few things including tonic/prost. Was experimenting with connect protocol since it can also use http1 for streaming.
If u have time to review u should take a look at the other pr that defines the protobuf schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Experiment with connect-rpc since it support streaming over http2 and http1 (connect protocol)
Stack created with Sapling. Best reviewed with ReviewStack.