Repository navigation
Redesign - #44
Redesign#44
Conversation
From source sans pro to dm sans DDF-504
Add new images and remove images that are no longer in use DDF-504
Change content texts and add new images DDF-504
DDF-504
Styling that adheres to the redesign and a refactor to remove redundant code and to make the code base simpler DDF-504
DDF-504
lieberkind
left a comment
There was a problem hiding this comment.
Nice! Nothing to add to this one really 😊
Note that I only looked at the code in this one, I didn't pull it down and run it.
As with the other PR - a before/after screenshot in the PR description is always nice for styling changes 💅
| ); | ||
| const visibleLibraries = libraries | ||
| .filter((lib) => lib.label.toLowerCase().includes(input.toLowerCase())) | ||
| .sort((a, b) => a.label.localeCompare(b.label)); |
There was a problem hiding this comment.
nitpick: Consider using .toSorted when sorting arrays 🔀 It doesn't matter too much in this case as .filter has already created a new array, but sort mutates the original array in place which can lead to some weird results 😅
| <Typography | ||
| as="p" | ||
| variant="p" | ||
| className="w-full !font-bold sm:text-center" |
There was a problem hiding this comment.
question: ...as I'm a Tailwind noob 😃 How does !font-bold work? Does it "unapply" the font-bold class?
There was a problem hiding this comment.
It works as an !important, which is the only way to overwrite the fonts in design system 🤷♀️
There was a problem hiding this comment.
Ah, that makes sense! Thanks for explaining 🙏
change endpint from /om-ereolen to /biblo DDF-504
Run @next/codemod and clean up its overreach: drop instant=false opt-outs, package-lock.json and npm overrides, restore caret ranges. Migrate next lint to eslint ., replace FlatCompat with eslint-config-next/core-web-vitals, bump CI Node to 22. No application code changed. DDF-765 assisted by: Claude code
The download card wrapped the Google Play and App Store links in an outer <a>, which is invalid HTML and broke hydration under Next 16. Drop the outer link so only the store icons are clickable. Predates the upgrade; Next 15 just did not report it. Assisted by Claude Code
Redesign: refresh visual styling, fonts, and branding assets
Description:
Swaps font family and logo/brand images, updates content and layout copy, and refactors styling across layout, header, footer, and UI components (button, dialog, popover, command) for a cleaner, more consistent design system.
I would reccomend to go commit by commit in the review.
DFF-504