Repository navigation
Redesign biblo go - #25
frontndNinja wants to merge 46 commits into
Conversation
The two previously used fonts have been swapped with the new font dm sans. DDF-505
To add an extra mobile breakpoint (xs) DDF-505
Add images for the new redesign DDF-505/DDF-506
Change texts to adhere to new design DDF-505/DDF-506
clean up css variables: delete the ones that are not in use and update the ones that we do use to adhere to the new redesign mockup. DDF-505/DDF-506
Fill cmdk’s hidden label and forward the search input ref so the combobox has accessible text. Fix kommune picker a11y: name the trigger, dialog, and search field so screen readers no longer find empty text. DDF-505/DDF-506
Remove images no longer used in the project DDF-505/DDF-506
DDF-505
There was a problem hiding this comment.
Looks super nice! 🏅 I don't have any blocking comments, apart from the fact that I want to make sure that this change is intended. Also left a few questions, but they aren't blocking this.
If the config change is good, please just ping me and I'll approve right away 😊
A tip for future PRs: when making this amount of styling changes, it can be super helpful with a few before/after screenshots in the PR description so the reviewer at a glance can understand what changes they're reviewing 💅
| font-weight: 500; | ||
| line-height: 12px; | ||
| letter-spacing: 0; | ||
| font-size: 16px; |
There was a problem hiding this comment.
question: This seems like quite a large change in font size for a caption. I suppose that this is what we want, right?
There was a problem hiding this comment.
Yes, it's because of the new design and the new font which is a lot smaller than the old one 😊
|
|
||
| --select-width: 42rem; | ||
| --radius: 0.75rem; | ||
| --background: #ffffff; |
There was a problem hiding this comment.
question: Was there a reason that we used oklch before and hex colors now?
There was a problem hiding this comment.
The old globals.css was just a copy/paste of the design system in go, where the colors are used differently. This repo now has it's own design sytem, completely separate of the go repo, as this is the only redesign yet (go has not been redesigned yet).
| {footerLinks.map((link, index) => ( | ||
| <li key={index}> | ||
| <Link target="_blank" href={link.href}> | ||
| <ul className="space-y-1" aria-label="Liste af nyttige links"> |
| const accessibleLabel = | ||
| label ?? (typeof ariaLabel === "string" ? ariaLabel : undefined); |
There was a problem hiding this comment.
nitpick (non-blocking): I think this expression can be simplified to just:
const accessibleLabel = label ?? ariaLabel;At least if ariaLabel has type string | undefined 😊
There was a problem hiding this comment.
Good eyes 👀 It has been corrected 🙂
| ); | ||
| } | ||
| }); | ||
| CommandInput.displayName = "CommandInput"; |
There was a problem hiding this comment.
praise: Nice. Makes debugging so much easier!
| import type { NextConfig } from "next"; | ||
|
|
||
| const basePath = process.env.NODE_ENV === "production" ? "/" : ""; | ||
| const basePath = process.env.NODE_ENV === "production" ? "" : ""; |
There was a problem hiding this comment.
comment: This seems a little dangerous to me. Just flagging it in case it wasn't supposed to be committed 😊
There was a problem hiding this comment.
The "/" value was actually broken: Next would prefix assets as //GO-bright-green.svg, a protocol-relative URL pointing at a host named GO-bright-green.svg. Setting it to "" fixed that. I just forgot cleaning the ternary up afterwards. I'll do that now 🙂
Ternary was redundant, since it returned the same result either way
To be able to pre-release the new design and brand for Biblo Go, we had to create a new github page. DDF-731
add github actions to deploy next project to github pages DDF-731
# Conflicts: # package.json # yarn.lock
…or a custom domain
Next 16 removes `next lint` and defaults to Turbopack, so scripts, ESLint config and CI Node version needed migrating. No application code changes were required. React bumped to ^19.3.1. DDF-764 Assisted by: Claude Code
The site is served from /biblogo on GitHub Pages but from the root locally, so a hardcoded prefix made every dev route 404 and the not-found handler redirect endlessly. Now derived per environment. DDF-764 Assisted by: Claude code
Claude hallucinated. Undo changes to buildRedirectParam DDF-764
Upgrade to next 16
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.3 to 8.5.23. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.3...8.5.23) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [source-map-js](https://github.com/7rulnik/source-map-js) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/7rulnik/source-map-js/releases) - [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md) - [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: source-map-js dependency-version: 1.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.21. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.21) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump postcss from 8.5.3 to 8.5.23
…sion-1.1.21 Bump brace-expansion from 1.1.11 to 1.1.21
…js-1.2.2 Bump source-map-js from 1.2.1 to 1.2.2
NB: SHOULD NOT BE MERGED YET!!!