Skip to content

Redesign biblo go - #25

Open
frontndNinja wants to merge 46 commits into
mainfrom
redesign-biblo-go
Open

frontndNinja wants to merge 46 commits into
mainfrom
redesign-biblo-go

Conversation

@frontndNinja

@frontndNinja frontndNinja commented Sep 2, 2026 •

Copy link
Copy Markdown

NB: SHOULD NOT BE MERGED YET!!!

  • Apply the GO redesign: DM Sans, updated copy, CSS tokens, new header/footer/cards artwork, and an xs (400px) breakpoint.
  • Make the municipality picker usable with screen readers by naming the trigger, dialog, and search field, and forwarding focus into the search input.
  • Use an empty production basePath so next build works for a root GitHub Pages site, and drop unused public assets and GT Flexa fonts.

The two previously used fonts have been swapped with the new font dm sans.

DDF-505
To add an extra mobile breakpoint (xs)

DDF-505
Add images for the new redesign

DDF-505/DDF-506
Change texts to adhere to new design

DDF-505/DDF-506
clean up css variables: delete the ones that are not in use and update the ones that we do use to adhere to the new redesign mockup.

DDF-505/DDF-506
Fill cmdk’s hidden label and forward the search input ref so the combobox has accessible text.
Fix kommune picker a11y: name the trigger, dialog, and search field so screen readers no longer find empty text.

DDF-505/DDF-506
Remove images no longer used in the project

DDF-505/DDF-506

@lieberkind lieberkind left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice! 🏅 I don't have any blocking comments, apart from the fact that I want to make sure that this change is intended. Also left a few questions, but they aren't blocking this.

If the config change is good, please just ping me and I'll approve right away 😊

A tip for future PRs: when making this amount of styling changes, it can be super helpful with a few before/after screenshots in the PR description so the reviewer at a glance can understand what changes they're reviewing 💅

Comment thread app/globals.css
font-weight: 500;
line-height: 12px;
letter-spacing: 0;
font-size: 16px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: This seems like quite a large change in font size for a caption. I suppose that this is what we want, right?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's because of the new design and the new font which is a lot smaller than the old one 😊

Comment thread app/globals.css

--select-width: 42rem;
--radius: 0.75rem;
--background: #ffffff;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Was there a reason that we used oklch before and hex colors now?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old globals.css was just a copy/paste of the design system in go, where the colors are used differently. This repo now has it's own design sytem, completely separate of the go repo, as this is the only redesign yet (go has not been redesigned yet).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! Thanks for clarifying 😊

Comment thread components/Footer.tsx
{footerLinks.map((link, index) => (
<li key={index}>
<Link target="_blank" href={link.href}>
<ul className="space-y-1" aria-label="Liste af nyttige links">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice with the aria-label! 🙌

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like accessibility 😄

Comment thread components/ui/command.tsx Outdated
Comment on lines +24 to +25
const accessibleLabel =
label ?? (typeof ariaLabel === "string" ? ariaLabel : undefined);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking): I think this expression can be simplified to just:

const accessibleLabel = label ?? ariaLabel;

At least if ariaLabel has type string | undefined 😊

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes 👀 It has been corrected 🙂

Comment thread components/ui/command.tsx
);
}
});
CommandInput.displayName = "CommandInput";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice. Makes debugging so much easier!

Comment thread next.config.ts Outdated
import type { NextConfig } from "next";

const basePath = process.env.NODE_ENV === "production" ? "/" : "";
const basePath = process.env.NODE_ENV === "production" ? "" : "";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: This seems a little dangerous to me. Just flagging it in case it wasn't supposed to be committed 😊

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "/" value was actually broken: Next would prefix assets as //GO-bright-green.svg, a protocol-relative URL pointing at a host named GO-bright-green.svg. Setting it to "" fixed that. I just forgot cleaning the ternary up afterwards. I'll do that now 🙂

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🙌

Ternary was redundant, since it returned the same result either way

@lieberkind lieberkind left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! 💯

frontndNinja and others added 19 commits October 28, 2026 14:25
Next 16 removes `next lint` and defaults to Turbopack, so scripts, ESLint
config and CI Node version needed migrating. No application code changes
were required. React bumped to ^19.3.1.
DDF-764

Assisted by: Claude Code
The site is served from /biblogo on GitHub Pages but from the root locally,
so a hardcoded prefix made every dev route 404 and the not-found handler
redirect endlessly. Now derived per environment.

DDF-764

Assisted by: Claude code
Claude hallucinated. Undo changes to buildRedirectParam
DDF-764
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.3 to 8.5.23.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.3...8.5.23)

---
updated-dependencies:
- dependency-name: postcss
  dependency-version: 8.5.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [source-map-js](https://github.com/7rulnik/source-map-js) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/7rulnik/source-map-js/releases)
- [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md)
- [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2)

---
updated-dependencies:
- dependency-name: source-map-js
  dependency-version: 1.2.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.21.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@1.1.11...v1.1.21)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.21
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…sion-1.1.21

Bump brace-expansion from 1.1.11 to 1.1.21
…js-1.2.2

Bump source-map-js from 1.2.1 to 1.2.2

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants