Skip to content

Add support for resource type commercial-marketplace-setup - #230

Merged
ashwgit merged 1 commit into
release-engineering:mainfrom
ashwinifork:add-resource-commercial-marketplace-setup
Sep 11, 2026
Merged

ashwgit merged 1 commit into
release-engineering:mainfrom
ashwinifork:add-resource-commercial-marketplace-setup

Conversation

@ashwgit

@ashwgit ashwgit commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@lslebodn @beerparty PTAL. This one adds support for resource type commercial-marketplace-setup in azure.

Summary by Sourcery

Add support for modeling and processing Azure commercial marketplace setup resources.

New Features:

  • Add Azure model support for the commercial-marketplace-setup resource, including marketplace sales, call-to-action, access, and licensing settings.
  • Register commercial-marketplace-setup as a supported Azure product resource.

Tests:

  • Add serialization, deserialization, enum, and service coverage for commercial marketplace setup resources.

@sourcery-ai

sourcery-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds end-to-end Azure support for the commercial-marketplace-setup resource by introducing its typed model, registering it in resource dispatch and service typing, and covering fixture integration plus serialization and optional license-management behavior.

File-Level Changes

Change Details Files
Add a typed model for the commercial marketplace setup resource and map it into Azure product resource handling.
  • Define required Microsoft sales flag and optional license-management flag with Azure JSON aliases.
  • Register the resource type for deserialization and include it in the Azure product resource union.
cloudpub/models/ms_azure.py
cloudpub/ms_azure/service.py
Add fixtures and coverage for parsing, serialization, metadata, and optional-field behavior.
  • Include the new resource in product fixtures.
  • Verify round-trip JSON conversion, linked product/resource properties, and both optional-field states.
tests/ms_azure/conftest.py
tests/ms_azure/test_models.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Sep 10, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ashwgit
ashwgit force-pushed the add-resource-commercial-marketplace-setup branch 2 times, most recently from 708239d to 54aa55d Compare September 11, 2026 07:25
@ashwgit
ashwgit force-pushed the add-resource-commercial-marketplace-setup branch from 54aa55d to a89c3d2 Compare September 11, 2026 08:52

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@lslebodn lslebodn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwgit
ashwgit merged commit 4a396cf into release-engineering:main Sep 11, 2026
9 of 10 checks passed
ashwgit added a commit to ashwinifork/cloudpub that referenced this pull request Sep 11, 2026
What's Changed

    Add support for resource type commercial-marketplace-setup by @ashwgit in release-engineering#230
ashwgit added a commit to ashwinifork/cloudpub that referenced this pull request Sep 11, 2026
What's Changed

    Add support for resource type commercial-marketplace-setup by @ashwgit in release-engineering#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants