Repository navigation
fix: exclude controller concerns from extraction and handle :: superclass - #28
Merged
Merged
Conversation
- Scanner should classify app/controllers/concerns/ as design_patterns, not controllers - Controller pattern should handle :: prefix on superclass (e.g. ::Spree::Api::V2::BaseController) - 4 new tests: 2 scanner, 1 pattern, 1 extractor integration
…e :: superclass - Scanner now classifies app/controllers/concerns/ as design_patterns (cat 26) before the broad controllers rule, preventing concern modules from being indexed as controllers - Controller classDeclaration pattern now handles optional :: prefix on superclass (e.g. ::Spree::Api::V2::BaseController) - Eval: get_controller mean composite 1.000 across 6 apps (164 controllers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes for the
get_controllertool:app/controllers/concerns/were classified as controllers::prefix on superclass failed to extractTesting