Skip to content

fix(docs): close six 1.0 docs-truth gaps #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremi wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix(docs): close six 1.0 docs-truth gaps #626

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
896370e
fix(docs): scope static-peer federation to the shipped inbound route
jeremi Aug 1, 2026
58fbcdf
fix(docs): exclude the audit pipeline from Notary PostgreSQL state cl…
jeremi Aug 1, 2026
52d3c30
fix(docs): retry pinned docs fetches and surface git stderr
jeremi Aug 1, 2026
12b74c5
fix(docs): keep diagram SVGs legible in dark mode
jeremi Aug 1, 2026
5924a73
fix(docs): anchor verified specs to inspectable artifacts
jeremi Aug 1, 2026
e41986a
fix(manifest): remove inert max_source_observed_age_seconds field
jeremi Aug 1, 2026
80e9b2f
fix(docs): resolve SVG class fills without rewriting the document
jeremi Aug 1, 2026
b7b3053
fix(docs): report SVG text fills the contrast gate cannot score
jeremi Aug 1, 2026
579179f
fix(docs): correct federation and audit-pipeline claims in the spec l…
jeremi Aug 1, 2026
159fc4c
fix(docs): resolve the effective fill when a CSS rule declares it twice
jeremi Aug 1, 2026
22c94f7
fix(docs): score reverse text against its chip and resolve the CSS ca…
jeremi Aug 1, 2026
ba27a38
fix(docs): stop claiming one Notary freshness control where several e…
jeremi Aug 1, 2026
284e041
docs(manifest): record the removed source-age key as a pre-1.0 break
jeremi Aug 1, 2026
03edb92
fix(docs): scope the manifest schema-version rule to 1.0 and later
jeremi Aug 1, 2026
360dc07
fix(docs): scope the capability matrix freshness claim to source obse…
jeremi Aug 1, 2026
aa8f3db
fix(docs): resolve CSS rules, shorthand hex, and tspan fills before s…
jeremi Aug 1, 2026
88d3a2d
fix(docs): honor inline style fills and require an adjacent backdrop
jeremi Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/registry-manifest-core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,6 @@ pub struct EvaluationProfileManifest {
pub claim_id: String,
pub subject_id_type: String,
#[serde(default, skip_serializing_if = "Option::is_none")]

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Split the change along owning-area boundaries

This commit combines a Manifest schema break under crates/, product-owned documentation under products/, docs-site scripts and specifications under docs/site/, and a release inventory edit under release/. Split these into owner-scoped changes so each owning area can be reviewed and verified independently, as the repository explicitly requires.

AGENTS.md reference: AGENTS.md:L77-L78

Useful? React with 👍 / 👎.

pub max_source_observed_age_seconds: Option<u64>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub evidence_pack: Option<EvidencePackMetadata>,
Comment on lines 569 to 570

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Version the manifest before removing this field

Any existing registry-manifest/v1 document containing the previously valid optional max_source_observed_age_seconds field now fails deserialization because this struct uses deny_unknown_fields. That contradicts the published V1 compatibility contract in products/manifest/docs/reference.md, which requires a new schema version when a change makes previously valid V1 manifests invalid; introduce a new manifest schema version or retain acceptance of the deprecated field during V1 parsing.

Useful? React with 👍 / 👎.

}

Expand Down
32 changes: 31 additions & 1 deletion crates/registry-manifest-core/tests/metadata_core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2117,7 +2117,6 @@ evaluation_profiles:
ruleset: age-eligibility-v1
claim_id: age_eligibility
subject_id_type: national_id
max_source_observed_age_seconds: 86400
requirements:
- id: age_requirement
title: Age requirement
Expand Down Expand Up @@ -2175,6 +2174,37 @@ fn federated_evaluation_manifest_validates_and_renders_catalog_fields() {
);
}

#[test]
fn evaluation_profile_rejects_removed_source_observed_age_field() {
let error = serde_yaml_ng::from_str::<MetadataManifest>(
r#"
schema_version: registry-manifest/v1
catalog:
id: removed-source-age
base_url: https://registry.example.test
title: Removed Source Age
publisher:
name: Example Registry
evaluation_profiles:
- id: age_eligibility_profile
ruleset: age-eligibility-v1
claim_id: age_eligibility
subject_id_type: national_id
max_source_observed_age_seconds: 86400
datasets: []
codelists: []
"#,
)
.expect_err("source-observation age is not a manifest field");

assert!(
error
.to_string()
.contains("max_source_observed_age_seconds"),
"the rejection must name the removed key; got: {error}"
);
}

#[test]
fn evaluation_profile_evidence_pack_parses_compiles_and_renders_catalog() {
let raw = r#"
Expand Down
2 changes: 0 additions & 2 deletions crates/registry-relay/demo/config/all_demos.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,10 @@ evaluation_profiles:
ruleset: benefits-person-v1
claim_id: benefits_person
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: education-student-v1
ruleset: education-student-v1
claim_id: education_student
subject_id_type: id
max_source_observed_age_seconds: 86400
requirements:
- id: benefits_person_requirement
iri: https://demo.example.gov/requirements/benefits-person
Expand Down
3 changes: 0 additions & 3 deletions crates/registry-relay/demo/config/all_standards.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,14 @@ evaluation_profiles:
ruleset: disability-status-v1
claim_id: disability_status
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: social-group-v1
ruleset: social-group-v1
claim_id: social_registry_group
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: farmer-status-v1
ruleset: farmer-status-v1
claim_id: farmer_status
subject_id_type: id
max_source_observed_age_seconds: 86400
requirements:
- id: disability_status_requirement
iri: https://demo.example.gov/requirements/disability-status
Expand Down
1 change: 0 additions & 1 deletion crates/registry-relay/demo/config/benefits_casework.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ evaluation_profiles:
ruleset: benefits-person-v1
claim_id: benefits_person
subject_id_type: id
max_source_observed_age_seconds: 86400
requirements:
- id: benefits_person_requirement
iri: https://demo.example.gov/requirements/benefits-person
Expand Down
3 changes: 0 additions & 3 deletions crates/registry-relay/demo/config/disability_registry.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,14 @@ evaluation_profiles:
ruleset: disability-status-v1
claim_id: disability_status
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: social-group-v1
ruleset: social-group-v1
claim_id: social_registry_group
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: farmer-status-v1
ruleset: farmer-status-v1
claim_id: farmer_status
subject_id_type: id
max_source_observed_age_seconds: 86400
requirements:
- id: disability_status_requirement
iri: https://demo.example.gov/requirements/disability-status
Expand Down
1 change: 0 additions & 1 deletion crates/registry-relay/demo/config/education_registry.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ evaluation_profiles:
ruleset: education-student-v1
claim_id: education_student
subject_id_type: id
max_source_observed_age_seconds: 86400
requirements:
- id: education_student_requirement
iri: https://demo.example.gov/requirements/education-student
Expand Down
3 changes: 0 additions & 3 deletions crates/registry-relay/tests/entity_routes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,14 @@ evaluation_profiles:
ruleset: exact-name
claim_id: exact_name
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: exact-name-targeted
ruleset: exact-name-targeted
claim_id: exact_name_targeted
subject_id_type: id
max_source_observed_age_seconds: 86400
- id: hidden-name
ruleset: hidden-name
claim_id: hidden_name
subject_id_type: id
max_source_observed_age_seconds: 86400
ecosystem_bindings:
- id: baseline-dpi/v1
version: v1
Expand Down
Loading
Loading