Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
services:
builder:
image: maven:3-eclipse-temurin-21@sha256:2b4496088e7b80ae10a8c9f74e574ea21380325a006ec684532ad6bad5bc7273
image: maven:3-eclipse-temurin-26@sha256:d5617b9a6307e1b51dc7c55edf09bacb66f1c91fb861949c34a3a0d4e16bd241

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the builder Java pin aligned with CI

For this release-area change, the documented release source check includes python3 -m unittest release/scripts/test_openid_conformance_runner.py, and that suite currently has test_builder_override_pins_maven_image_by_digest asserting the builder override stays on maven:3-eclipse-temurin-21@sha256:. Changing this line to Temurin 26 makes that required check fail immediately; keep the builder on the expected JDK 21 pin or update the runner/test contract together if the suite is intentionally moving Java levels.

AGENTS.md reference: AGENTS.md:L56-L60

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the builder Java pin aligned with CI

For this release-area change, the documented release source check includes python3 -m unittest release/scripts/test_openid_conformance_runner.py, and that suite currently has test_builder_override_pins_maven_image_by_digest asserting the builder override stays on maven:3-eclipse-temurin-21@sha256:. Changing this line to Temurin 26 makes that required check fail immediately; keep the builder on the expected JDK 21 pin or update the runner/test contract together if the suite is intentionally moving Java levels.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the missing DCO sign-off

This commit has no Signed-off-by: trailer, and the repository’s DCO workflow checks every non-merge commit in the PR range and exits nonzero when that trailer is absent. Please amend/recreate the commit with git commit -s so the DCO gate can pass.

Useful? React with 👍 / 👎.

2 changes: 1 addition & 1 deletion release/conformance/openid/docker-compose.override.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
mongodb:
image: mongo:6.0.13@sha256:b415b12f638e2685d06c58ab7fb5943577c50fadec6d9340ef67d21aeac72070
image: mongo:8.2.12@sha256:e0ce8c35124d4a9f9785532d1f268f39e9728ffa1cb38f46fa482436424c4bd3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid jumping persisted Mongo data straight to 8.2

When an operator reuses the default conformance checkout after any prior run, the pinned upstream compose file’s ./mongo/data:/data/db bind mount preserves Mongo 6.0 data across down, but this override now starts that same data directory with Mongo 8.2. MongoDB’s standalone 8.2 upgrade guide says existing deployments must already be 8.0-series and earlier versions must be upgraded successively, so the suite can fail to start until the local data is manually deleted or migrated; either keep this on 6.0/perform a supported intermediate upgrade, or make the runner clear/migrate the ignored data directory for this major bump. See upstream compose and MongoDB’s upgrade path docs: https://raw.githubusercontent.com/openid-certification/conformance-suite/dee9a25160e789f0f80517674693ef7989ab9fa1/docker-compose.yml and https://www.mongodb.com/docs/manual/release-notes/8.2-upgrade-standalone/.

Useful? React with 👍 / 👎.

nginx:
build:
context: ./nginx
Expand Down
Loading