Add MinGW Windows packaging support - #5308
Open
liuliuzo wants to merge 1 commit into
Open
Conversation
liuliuzo
marked this pull request as ready for review
August 1, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The generated Windows binaries are local artifacts and are not included in this PR.
Note
Low Risk
Changes are limited to build and installer configuration; the registry key update may affect alignment with prior installs but does not touch application runtime logic.
Overview
Adds a MinGW (
win32-g++) link path in3rdparty.prithat requiresWINDOWS_MINGW_BUILD_ROOTandMINGW_ROOTand pulls static zlib/lz4/zstd/snappy/brotli from those trees, while MSVCwin32*behavior stays on the existing NuGet-style libs.Windows Python embedding can use an optional
PYTHON_ROOTinstead of a fixedC:\Python38-x64path. Including PyOtherSide no longer overwrites the appVERSIONforPYOTHERSIDE_VERSION; the RESP version is saved and restored around the subproject include.NSIS packaging fixes the registry key to
SOFTWARE\RESP.app, allowsSOURCE_DIR/OUTPUT_FILE, andSKIP_VCREDISTfor MinGW builds that do not need the MSVC runtime.qt.confnow uses a local prefix with explicitpluginsandqmlpaths so a portable directory layout resolves Qt assets correctly.Reviewed by Cursor Bugbot for commit f93d7d5. Bugbot is set up for automated code reviews on this repo. Configure here.