BugFix: enumerate groups | Narrow TLS1.2-TLS1.0 group-scan cipher list to ECDHE/DHE suites only - #364
Open
jalilm wants to merge 1 commit into
Open
Conversation
Only ECDHE and DHE suites cause SSL_get_server_tmp_key to succeed and produce a group/curve in sslscan output. Static-KX suites (RSA, DH, ECDH) never generate a ServerKeyExchange with group parameters and are therefore useless in this scan path. Also removes deprecated algorithms (RC4, 3DES, SEED, Camellia). Reduces list from 85 suites (170 bytes) to 24 + SCSV (50 bytes).
jalilm
force-pushed
the
chore/narrow-group-scan-cipherlist
branch
from
August 23, 2026 22:19
fd89ab0 to
3055505
Compare
jalilm
changed the title
Owner
|
Thanks for submitting this. @jtesta I think you were involved in (or possibly wrote) this code - any comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the 170-byte (85-suite) hardcoded cipher list in
testSupportedGroupsfor TLS 1.2 with a 50-byte (24-suite + SCSV) ephemeral-only list. Only ECDHE/DHE suites causeSSL_get_server_tmp_keyto succeed and produce a named group in sslscan output — static-KX suites (RSA, DH, ECDH) never issue a ServerKeyExchange with group parameters and are useless in this scan path. Also removes deprecated algorithms (RC4, 3DES, SEED, Camellia). Original comment updated to document the reasoning.