Repository navigation
Repo tidy-up: lint, tests, CI, README, remove unused Outlook code - #1
Merged
Merged
Conversation
Outlook sign-in is being built on a separate branch; on main it was hidden behind SHOW_OUTLOOK and never reachable. Google sign-in is unchanged.
- eslint.config.mjs (next/core-web-vitals + next/typescript), npm run lint - npm run typecheck, npm test (Vitest) for headers, companies, updates and the PIN lock - CI runs typecheck, lint, test and build on pushes and pull requests to main - drop the redundant desktop:build script
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the repo easier to read and safer to change. Nothing is released; the app's behaviour is unchanged.
Lint and CI
eslint.config.mjs(flat config,next/core-web-vitals+next/typescript). Rules turned off, with the reason in the config:no-html-link-for-pages(/is rewritten by the middleware and/api/connect/*are API redirects, so full page loads are what we want) andno-img-element(static images, no next/image in the standalone desktop server).no-unused-varsignores rest siblings (we drop token fields with destructuring).lint,typecheck,test..github/workflows/ci.yml:npm ci, typecheck, lint, test andnext buildon pushes and PRs tomain. It skips the Electron binary download.Tests (Vitest, 37 tests)
headers.ts:decodeWords,parseFrom,parseListUnsubscribecompanies.ts:companyDomainupdates.ts:isNewerapplock.ts: PIN set/check/remove and the rate limit (5 free tries, then 30 s doubling up to 1 h, and the counter resets after a correct PIN). Uses a temporaryDATA_DIRand fake timers.Dead code
src/lib/providers/microsoft.ts,SHOW_OUTLOOK, and themicrosoftprovider in accounts, AddAccount, Dashboard, the connect routes, middleware, catalog,prepare-desktop.mjsand.env.example. Google sign-in still works the same way.desktop:buildscript.public/screenshots/filter-dark.png, becausescripts/capture.cjsstill generates it.README
electron/package.jsonis the source of truth), and the Store workflow.Checked locally:
npm run typecheck,npm run lint,npm testandnpm run buildall pass.